Re: [PATCH RFC 1/2] btrfs: scrub: Don't use inode page cache in scrub_handle_errored_block()

2018-07-10 Thread Nikolay Borisov
On 10.07.2018 10:14, Qu Wenruo wrote: > > > On 2018年07月10日 15:00, Nikolay Borisov wrote: >> >> >> On 10.07.2018 08:57, Qu Wenruo wrote: >>> When we need to fixup error blocks during scrub/dev-replace for >>> nodatasum extents, we still goes through the inode page cache and write >>> them back

Re: [PATCH RFC 1/2] btrfs: scrub: Don't use inode page cache in scrub_handle_errored_block()

2018-07-10 Thread Qu Wenruo
On 2018年07月10日 15:00, Nikolay Borisov wrote: > > > On 10.07.2018 08:57, Qu Wenruo wrote: >> When we need to fixup error blocks during scrub/dev-replace for >> nodatasum extents, we still goes through the inode page cache and write >> them back onto disk. >> >> It's already proved that such usa

Re: [PATCH RFC 1/2] btrfs: scrub: Don't use inode page cache in scrub_handle_errored_block()

2018-07-10 Thread Nikolay Borisov
On 10.07.2018 08:57, Qu Wenruo wrote: > When we need to fixup error blocks during scrub/dev-replace for > nodatasum extents, we still goes through the inode page cache and write > them back onto disk. > > It's already proved that such usage of on-disk data could lead to > serious data corruptio

[PATCH RFC 1/2] btrfs: scrub: Don't use inode page cache in scrub_handle_errored_block()

2018-07-09 Thread Qu Wenruo
When we need to fixup error blocks during scrub/dev-replace for nodatasum extents, we still goes through the inode page cache and write them back onto disk. It's already proved that such usage of on-disk data could lead to serious data corruption for compressed extent. So here we also need to avoi