Re: [PATCH RFCv2] new ioctl TREE_SEARCH_V2

2014-01-28 Thread Gerhard Heift
2014-01-28 Anand Jain : > You may have covered this but its not explicit. > Could you write few lines on whats wrong with the current > TREE SEARCH and how V2 is helping. I wrote a program, which basically calculates a checksum over a files content checksums. First I got the fiemap of the file

Re: [PATCH RFCv2] new ioctl TREE_SEARCH_V2

2014-01-28 Thread Anand Jain
You may have covered this but its not explicit. Could you write few lines on whats wrong with the current TREE SEARCH and how V2 is helping. Thanks, Anand On 01/27/2014 09:28 PM, Gerhard Heift wrote: This patch series adds a new ioctl TREE_SEARCH_V2 with which we could store the results

Re: [PATCH RFCv2] new ioctl TREE_SEARCH_V2

2014-01-27 Thread Goffredo Baroncelli
Hi Hugo, On 2014-01-27 20:31, Hugo Mills wrote: >> > One of the main strangeness of the current TREE_SEARCH ioctl, which I >> > found is the fact that the search was not in a "rectangular" region, but >> > in a "linear" region. >> > This is due the fact that after a ioctl call, we have to set the

Re: [PATCH RFCv2] new ioctl TREE_SEARCH_V2

2014-01-27 Thread Hugo Mills
On Mon, Jan 27, 2014 at 08:10:52PM +0100, Goffredo Baroncelli wrote: > Hi, > > On 2014-01-27 14:28, Gerhard Heift wrote: > > This patch series adds a new ioctl TREE_SEARCH_V2 with which we could store > > the > > results in a varying buffer. Now even items larger than 3992 bytes or a > > large >

Re: [PATCH RFCv2] new ioctl TREE_SEARCH_V2

2014-01-27 Thread Goffredo Baroncelli
Hi, On 2014-01-27 14:28, Gerhard Heift wrote: > This patch series adds a new ioctl TREE_SEARCH_V2 with which we could store > the > results in a varying buffer. Now even items larger than 3992 bytes or a large > amount of items can be returned. One of the main strangeness of the current TREE_SE

Re: [PATCH RFCv2] new ioctl TREE_SEARCH_V2

2014-01-27 Thread David Sterba
On Mon, Jan 27, 2014 at 02:28:26PM +0100, Gerhard Heift wrote: > This patch series adds a new ioctl TREE_SEARCH_V2 with which we could store > the > results in a varying buffer. Now even items larger than 3992 bytes or a large > amount of items can be returned. > > I have a few questions: > Whi

[PATCH RFCv2] new ioctl TREE_SEARCH_V2

2014-01-27 Thread Gerhard Heift
This patch series adds a new ioctl TREE_SEARCH_V2 with which we could store the results in a varying buffer. Now even items larger than 3992 bytes or a large amount of items can be returned. I have a few questions: Which value should I assign to TREE_SEARCH_V2? Should we limit the buffer size?