Re: [PATCH RFCv2 2/6] btrfs: search_ioctl rejects unused setted values

2014-01-29 Thread David Sterba
On Tue, Jan 28, 2014 at 01:32:36AM +0100, Gerhard Heift wrote: If any future version of the ioctl uses the now unused fields, it also has to increase the version. Just for me to learn: If we have to increase the version, why do we have the unused fields anyway? We could expand the struct

[PATCH RFCv2 2/6] btrfs: search_ioctl rejects unused setted values

2014-01-27 Thread Gerhard Heift
To prevent unexpectet values in the unused fields of the search key fail early. Otherwise future extensions would break the behavior of the search if current implementations in userspace set them to values other than zero. Signed-off-by: Gerhard Heift gerh...@heift.name --- fs/btrfs/ioctl.c | 3

Re: [PATCH RFCv2 2/6] btrfs: search_ioctl rejects unused setted values

2014-01-27 Thread David Sterba
On Mon, Jan 27, 2014 at 02:28:28PM +0100, Gerhard Heift wrote: To prevent unexpectet values in the unused fields of the search key fail early. Otherwise future extensions would break the behavior of the search if current implementations in userspace set them to values other than zero.

Re: [PATCH RFCv2 2/6] btrfs: search_ioctl rejects unused setted values

2014-01-27 Thread Martin Steigerwald
Am Montag, 27. Januar 2014, 14:28:28 schrieb Gerhard Heift: To prevent unexpectet values in the unused fields of the search key fail unexpected early. Otherwise future extensions would break the behavior of the search if current implementations in userspace set them to values other than zero.

Re: [PATCH RFCv2 2/6] btrfs: search_ioctl rejects unused setted values

2014-01-27 Thread Gerhard Heift
2014-01-27 David Sterba dste...@suse.cz: On Mon, Jan 27, 2014 at 02:28:28PM +0100, Gerhard Heift wrote: To prevent unexpectet values in the unused fields of the search key fail early. Otherwise future extensions would break the behavior of the search if current implementations in userspace