Re: [PATCH V4 5/7] Btrfs-progs: restructure list_subvolumes

2012-09-20 Thread David Sterba
On Tue, Sep 18, 2012 at 07:06:49PM +0800, Miao Xie wrote: The current code of list_subvols() has very bad scalability, if we want to add new filter conditions or new sort methods, we have to modify lots of code. I've briefly skimmed through the patch, not a short one, IMO the right way to go.

[PATCH V4 5/7] Btrfs-progs: restructure list_subvolumes

2012-09-18 Thread Miao Xie
The current code of list_subvols() has very bad scalability, if we want to add new filter conditions or new sort methods, we have to modify lots of code. Beside that, the most code of list_snapshots() is similar to list_subvols(), So I restructure list_subvols(), and split the subvolume filter