Re: [PATCH v2] Btrfs: add parent_transid parameter to veirfy_level_key

2018-05-25 Thread David Sterba
On Fri, May 18, 2018 at 01:10:59PM +0800, Qu Wenruo wrote: > > > On 2018年05月18日 13:02, Nikolay Borisov wrote: > > > > > > On 18.05.2018 05:59, Liu Bo wrote: > >> As verify_level_key() is checked after verify_parent_transid(), i.e. > >> > >> if (verify_parent_transid()) > >>ret = -EIO; > >>

Re: [PATCH v2] Btrfs: add parent_transid parameter to veirfy_level_key

2018-05-17 Thread Qu Wenruo
On 2018年05月18日 13:02, Nikolay Borisov wrote: > > > On 18.05.2018 05:59, Liu Bo wrote: >> As verify_level_key() is checked after verify_parent_transid(), i.e. >> >> if (verify_parent_transid()) >>ret = -EIO; >> else if (verify_level_key()) >>ret = -EUCLEAN; >> >> if parent_transid is 0,

Re: [PATCH v2] Btrfs: add parent_transid parameter to veirfy_level_key

2018-05-17 Thread Qu Wenruo
On 2018年05月18日 10:59, Liu Bo wrote: > As verify_level_key() is checked after verify_parent_transid(), i.e. > > if (verify_parent_transid()) >ret = -EIO; > else if (verify_level_key()) >ret = -EUCLEAN; > > if parent_transid is 0, verify_parent_transid() skips verifying > parent_transid

Re: [PATCH v2] Btrfs: add parent_transid parameter to veirfy_level_key

2018-05-17 Thread Nikolay Borisov
On 18.05.2018 05:59, Liu Bo wrote: > As verify_level_key() is checked after verify_parent_transid(), i.e. > > if (verify_parent_transid()) >ret = -EIO; > else if (verify_level_key()) >ret = -EUCLEAN; > > if parent_transid is 0, verify_parent_transid() skips verifying > parent_transid

[PATCH v2] Btrfs: add parent_transid parameter to veirfy_level_key

2018-05-17 Thread Liu Bo
As verify_level_key() is checked after verify_parent_transid(), i.e. if (verify_parent_transid()) ret = -EIO; else if (verify_level_key()) ret = -EUCLEAN; if parent_transid is 0, verify_parent_transid() skips verifying parent_transid and considers eb as valid, and if verify_level_key()