Re: [PATCH v2] Btrfs: kill btrfs_clear_path_blocking

2018-08-22 Thread Liu Bo
On Wed, Aug 22, 2018 at 03:13:28PM +0200, David Sterba wrote: > On Wed, Aug 22, 2018 at 05:54:37AM +0800, Liu Bo wrote: > > w/o patch: > > real2m27.307s > > user0m12.839s > > sys 13m42.831s > > > > w/ patch: > > real1m2.273s > > user0m15.802s > > sys 8m16.495s > > This loo

Re: [PATCH v2] Btrfs: kill btrfs_clear_path_blocking

2018-08-22 Thread David Sterba
On Wed, Aug 22, 2018 at 05:54:37AM +0800, Liu Bo wrote: > w/o patch: > real2m27.307s > user0m12.839s > sys 13m42.831s > > w/ patch: > real1m2.273s > user0m15.802s > sys 8m16.495s This looks good. The change does not have any potential correctness problems right? I'm asking

[PATCH v2] Btrfs: kill btrfs_clear_path_blocking

2018-08-21 Thread Liu Bo
Btrfs's btree locking has two modes, spinning mode and blocking mode, while searching btree, locking is always acquired in spinning mode and then converted to blocking mode if necessary, and in some hot paths we may switch the locking back to spinning mode by btrfs_clear_path_blocking(). When acqu