Re: [PATCH v2] Btrfs-progs: add dedup subcommand

2013-09-02 Thread David Sterba
On Mon, Aug 12, 2013 at 10:45:55AM +0800, Liu Bo wrote: > On Fri, Aug 09, 2013 at 02:51:35PM +0200, David Sterba wrote: > > I'm not sure that calling it register/unregister is the right thing, IMO > > it's more enable/disable as you write in the documentation under each > > respective command. > >

Re: [PATCH v2] Btrfs-progs: add dedup subcommand

2013-08-11 Thread Liu Bo
On Fri, Aug 09, 2013 at 02:51:35PM +0200, David Sterba wrote: > On Thu, Aug 08, 2013 at 04:35:46PM +0800, Liu Bo wrote: > > This aims to add deduplication subcommand, 'btrfs dedup command ', > > ie. register/unregister'. > > I'm not sure that calling it register/unregister is the right thing, IMO

Re: [PATCH v2] Btrfs-progs: add dedup subcommand

2013-08-09 Thread David Sterba
On Thu, Aug 08, 2013 at 04:35:46PM +0800, Liu Bo wrote: > This aims to add deduplication subcommand, 'btrfs dedup command ', > ie. register/unregister'. I'm not sure that calling it register/unregister is the right thing, IMO it's more enable/disable as you write in the documentation under each re

[PATCH v2] Btrfs-progs: add dedup subcommand

2013-08-08 Thread Liu Bo
This aims to add deduplication subcommand, 'btrfs dedup command ', ie. register/unregister'. It can be used to enable or disable dedup support for a filesystem. Signed-off-by: Liu Bo --- v2: add manpage Makefile |2 +- btrfs.c|1 + cmds-dedup.c | 101 ++