Re: [PATCH v2 06/10] btrfs-progs: kernel-lib: Port kernel sort() to btrfs-progs

2018-03-09 Thread David Sterba
On Thu, Feb 22, 2018 at 09:43:37AM +0800, Qu Wenruo wrote: > > > On 2018年02月21日 23:40, David Sterba wrote: > > On Fri, Feb 09, 2018 at 03:44:24PM +0800, Qu Wenruo wrote: > >> Used by later btrfs_alloc_chunk() rework. > > > > We have the libc provided qsort, so please don't pull another > > imple

Re: [PATCH v2 06/10] btrfs-progs: kernel-lib: Port kernel sort() to btrfs-progs

2018-02-21 Thread Qu Wenruo
On 2018年02月21日 23:40, David Sterba wrote: > On Fri, Feb 09, 2018 at 03:44:24PM +0800, Qu Wenruo wrote: >> Used by later btrfs_alloc_chunk() rework. > > We have the libc provided qsort, so please don't pull another > implementation but rather add a wrapper. Thanks for pointing this out. Another

Re: [PATCH v2 06/10] btrfs-progs: kernel-lib: Port kernel sort() to btrfs-progs

2018-02-21 Thread David Sterba
On Fri, Feb 09, 2018 at 03:44:24PM +0800, Qu Wenruo wrote: > Used by later btrfs_alloc_chunk() rework. We have the libc provided qsort, so please don't pull another implementation but rather add a wrapper. > --- /dev/null > +++ b/kernel-lib/sort.c > @@ -0,0 +1,104 @@ > +/* > + * taken from linux

[PATCH v2 06/10] btrfs-progs: kernel-lib: Port kernel sort() to btrfs-progs

2018-02-08 Thread Qu Wenruo
Used by later btrfs_alloc_chunk() rework. Signed-off-by: Qu Wenruo --- Makefile | 3 +- kernel-lib/sort.c | 104 ++ kernel-lib/sort.h | 16 + 3 files changed, 122 insertions(+), 1 deletion(-) create mode 100644 kernel-lib/s