Re: [PATCH v2 1/2] btrfs: fix device order consistency

2018-01-30 Thread Anand Jain
+static int device_sort(void *priv, struct list_head *a, struct list_head *b) I'll rename that to devid_cmp as it's the comparator and not really a sorting function. Ok. I will make that change in v3. Thanks, Anand -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 1/2] btrfs: fix device order consistency

2018-01-30 Thread David Sterba
On Mon, Jan 22, 2018 at 02:49:36PM -0800, Anand Jain wrote: > By maintaining the device order consistency it makes reproducing > the problems related to missing chunk in the degraded mode much more > consistent. So fix this by sorting the devices by devid within the > kernel. So that we know which

[PATCH v2 1/2] btrfs: fix device order consistency

2018-01-22 Thread Anand Jain
By maintaining the device order consistency it makes reproducing the problems related to missing chunk in the degraded mode much more consistent. So fix this by sorting the devices by devid within the kernel. So that we know which device is assigned to the struct fs_info::latest_bdev when all the