Re: [PATCH v2 2/2] btrfs: fix missing superblock update in the device delete commit transaction

2018-07-25 Thread Anand Jain
On 07/24/2018 07:01 PM, David Sterba wrote: On Tue, Jul 24, 2018 at 05:28:03PM +0800, Lu Fengqi wrote: I can't reproduce the issue. Do you reproduce consistently? and I Sorry I've taken so long to reply. There are four virtual machines with the different storage backend here. And I can

Re: [PATCH v2 2/2] btrfs: fix missing superblock update in the device delete commit transaction

2018-07-24 Thread David Sterba
On Tue, Jul 24, 2018 at 05:28:03PM +0800, Lu Fengqi wrote: > >I can't reproduce the issue. Do you reproduce consistently? and I > > Sorry I've taken so long to reply. > > There are four virtual machines with the different storage backend here. > And I can reproduce this issue consistently on the

Re: [PATCH v2 2/2] btrfs: fix missing superblock update in the device delete commit transaction

2018-07-24 Thread Lu Fengqi
On Mon, Jul 23, 2018 at 03:52:59PM +0800, Anand Jain wrote: > > >On 07/21/2018 02:01 PM, Lu Fengqi wrote: >> On Tue, Jul 03, 2018 at 05:07:24PM +0800, Anand Jain wrote: >> > When a device is deleted, the btrfs_super_block::number_devices is >> > reduced by 1, but we do that after the commit

Re: [PATCH v2 2/2] btrfs: fix missing superblock update in the device delete commit transaction

2018-07-23 Thread Anand Jain
On 07/21/2018 02:01 PM, Lu Fengqi wrote: On Tue, Jul 03, 2018 at 05:07:24PM +0800, Anand Jain wrote: When a device is deleted, the btrfs_super_block::number_devices is reduced by 1, but we do that after the commit transaction, so this change did not made it to the disk and waits for the next

Re: [PATCH v2 2/2] btrfs: fix missing superblock update in the device delete commit transaction

2018-07-21 Thread Lu Fengqi
On Tue, Jul 03, 2018 at 05:07:24PM +0800, Anand Jain wrote: >When a device is deleted, the btrfs_super_block::number_devices is >reduced by 1, but we do that after the commit transaction, so this >change did not made it to the disk and waits for the next commit >transaction whenever it happens. >

Re: [PATCH v2 2/2] btrfs: fix missing superblock update in the device delete commit transaction

2018-07-05 Thread David Sterba
On Tue, Jul 03, 2018 at 05:07:24PM +0800, Anand Jain wrote: > When a device is deleted, the btrfs_super_block::number_devices is > reduced by 1, but we do that after the commit transaction, so this > change did not made it to the disk and waits for the next commit > transaction whenever it

[PATCH v2 2/2] btrfs: fix missing superblock update in the device delete commit transaction

2018-07-03 Thread Anand Jain
When a device is deleted, the btrfs_super_block::number_devices is reduced by 1, but we do that after the commit transaction, so this change did not made it to the disk and waits for the next commit transaction whenever it happens. This can be easily demonstrated using the following test case