Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()

2018-12-03 Thread Johannes Thumshirn
On 28/11/2018 16:41, David Sterba wrote: > On Wed, Nov 28, 2018 at 09:54:55AM +0100, Johannes Thumshirn wrote: >> In map_private_extent_buffer() use offset_in_page() to initialize >> 'start_offset' instead of open-coding it. > > Can you please fix all instances where it's opencoded? Grepping for

Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()

2018-11-28 Thread David Sterba
On Wed, Nov 28, 2018 at 09:54:55AM +0100, Johannes Thumshirn wrote: > In map_private_extent_buffer() use offset_in_page() to initialize > 'start_offset' instead of open-coding it. Can you please fix all instances where it's opencoded? Grepping for 'PAGE_SIZE - 1' finds a number of them. Thanks.

[PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()

2018-11-28 Thread Johannes Thumshirn
In map_private_extent_buffer() use offset_in_page() to initialize 'start_offset' instead of open-coding it. Signed-off-by: Johannes Thumshirn Reviewed-by: Nikolay Borisov --- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c