Re: [PATCH v2 3/4] btrfs: Add zstd support

On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: > +static void zstd_free_workspace(struct list_head *ws) > +{ > + struct workspace *workspace = list_entry(ws, struct workspace, list); > + > + vfree(workspace->mem); > + kfree(workspace->buf); > + kfree(workspace); > +}

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Tue, Jul 11, 2017 at 06:01:38AM +, Nick Terrell wrote: > On 7/10/17, 9:57 PM, "Nick Terrell" wrote: > > The problem is caused by a gcc-7 bug [1]. It miscompiles > > ZSTD_wildcopy(void *dst, void const *src, ptrdiff_t len) when len is 0. > > Sorry, my patch still triggered

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 7/10/17, 9:57 PM, "Nick Terrell" wrote: > The problem is caused by a gcc-7 bug [1]. It miscompiles > ZSTD_wildcopy(void *dst, void const *src, ptrdiff_t len) when len is 0. > It only happens when it can't analyze ZSTD_copy8(), which is the case in > the kernel, because

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 7/10/17, 5:36 AM, "Austin S. Hemmelgarn" wrote: > On 2017-07-07 23:07, Adam Borowski wrote: >> On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: >>> On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: On 7/6/17, 9:32 AM, "Adam Borowski"

Re: [PATCH v2 3/4] btrfs: Add zstd support

> So, I don't see any problem making the level configurable. +1 - configureable compression level would be very appreciated from my side. Can't wait until zstd support is mainline :) Thanks and br, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 7/10/17, 5:36 AM, "Austin S. Hemmelgarn" wrote: > On 2017-07-07 23:07, Adam Borowski wrote: >> On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: >>> On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: On 7/6/17, 9:32 AM, "Adam Borowski"

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-07-07 23:07, Adam Borowski wrote: On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: On 7/6/17, 9:32 AM, "Adam Borowski" wrote: Got a reproducible crash on amd64: Thanks for the bug

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: > On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: > > On 7/6/17, 9:32 AM, "Adam Borowski" wrote: > > > Got a reproducible crash on amd64: > > > Thanks for the bug report Adam! I'm looking into the

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: > On 7/6/17, 9:32 AM, "Adam Borowski" wrote: > > Got a reproducible crash on amd64: > > > > [98235.266511] BUG: unable to handle kernel paging request at > > c90001251000 > > [98235.314008] ?

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 7/6/17, 9:32 AM, "Adam Borowski" wrote: > On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: >> Add zstd compression and decompression support to BtrFS. zstd at its >> fastest level compresses almost as well as zlib, while offering much >> faster compression and

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. zstd at its > fastest level compresses almost as well as zlib, while offering much > faster compression and decompression, approaching lzo speeds. Got a reproducible crash on

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-07-06 08:09, Lionel Bouton wrote: Le 06/07/2017 à 13:59, Austin S. Hemmelgarn a écrit : On 2017-07-05 20:25, Nick Terrell wrote: On 7/5/17, 12:57 PM, "Austin S. Hemmelgarn" wrote: It's the slower compression speed that has me arguing for the possibility of

Re: [PATCH v2 3/4] btrfs: Add zstd support

Le 06/07/2017 à 13:59, Austin S. Hemmelgarn a écrit : > On 2017-07-05 20:25, Nick Terrell wrote: >> On 7/5/17, 12:57 PM, "Austin S. Hemmelgarn" >> wrote: >>> It's the slower compression speed that has me arguing for the >>> possibility of configurable levels on zlib. 11MB/s

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-07-05 20:25, Nick Terrell wrote: On 7/5/17, 12:57 PM, "Austin S. Hemmelgarn" wrote: It's the slower compression speed that has me arguing for the possibility of configurable levels on zlib. 11MB/s is painfully slow considering that most decent HDD's these days

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 7/5/17, 12:57 PM, "Austin S. Hemmelgarn" wrote: > It's the slower compression speed that has me arguing for the > possibility of configurable levels on zlib. 11MB/s is painfully slow > considering that most decent HDD's these days can get almost 5-10x that > speed

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-07-05 15:35, Nick Terrell wrote: On 7/5/17, 11:45 AM, "Austin S. Hemmelgarn" wrote: On 2017-07-05 14:18, Adam Borowski wrote: On Wed, Jul 05, 2017 at 07:43:27AM -0400, Austin S. Hemmelgarn wrote: On 2017-06-30 19:01, Nick Terrell wrote: There is also the fact

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 7/5/17, 11:45 AM, "Austin S. Hemmelgarn" wrote: >On 2017-07-05 14:18, Adam Borowski wrote: >> On Wed, Jul 05, 2017 at 07:43:27AM -0400, Austin S. Hemmelgarn >> wrote: >>> On 2017-06-30 19:01, Nick Terrell wrote: > There is also the fact of deciding what to use for the

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-07-05 14:18, Adam Borowski wrote: On Wed, Jul 05, 2017 at 07:43:27AM -0400, Austin S. Hemmelgarn wrote: On 2017-06-30 19:01, Nick Terrell wrote: There is also the fact of deciding what to use for the default when specified without a level. This is easy for lzo and zlib, where we can

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Wed, Jul 05, 2017 at 07:43:27AM -0400, Austin S. Hemmelgarn wrote: > On 2017-06-30 19:01, Nick Terrell wrote: > > > There is also the fact of deciding what to use for the default when > > > specified without a level. This is easy for lzo and zlib, where we can > > > just use the existing

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-06-30 19:01, Nick Terrell wrote: If we're going to make that configurable, there are some things to consider: * the underlying compressed format -- does not change for different levels This is true for zlib and zstd. lzo in the kernel only supports one compression level. I had

Re: [PATCH v2 3/4] btrfs: Add zstd support

>> If we're going to make that configurable, there are some things to >> consider: >> >> * the underlying compressed format -- does not change for different >>levels This is true for zlib and zstd. lzo in the kernel only supports one compression level. >> * the configuration interface --

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-06-30 10:21, David Sterba wrote: On Fri, Jun 30, 2017 at 08:16:20AM -0400, E V wrote: On Thu, Jun 29, 2017 at 3:41 PM, Nick Terrell wrote: Add zstd compression and decompression support to BtrFS. zstd at its fastest level compresses almost as well as zlib, while

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Fri, Jun 30, 2017 at 08:16:20AM -0400, E V wrote: > On Thu, Jun 29, 2017 at 3:41 PM, Nick Terrell wrote: > > Add zstd compression and decompression support to BtrFS. zstd at its > > fastest level compresses almost as well as zlib, while offering much > > faster compression and

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Thu, Jun 29, 2017 at 3:41 PM, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. zstd at its > fastest level compresses almost as well as zlib, while offering much > faster compression and decompression, approaching lzo speeds. > > I benchmarked

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. zstd at its > fastest level compresses almost as well as zlib, while offering much > faster compression and decompression, approaching lzo speeds. > +static int

[PATCH v2 3/4] btrfs: Add zstd support

Add zstd compression and decompression support to BtrFS. zstd at its fastest level compresses almost as well as zlib, while offering much faster compression and decompression, approaching lzo speeds. I benchmarked btrfs with zstd compression against no compression, lzo compression, and zlib