Re: [PATCH v2 3/6] btrfs: Make compress_file_range take only struct async_cow

2019-02-21 Thread Johannes Thumshirn
On 21/02/2019 12:55, Nikolay Borisov wrote: > > > On 20.02.19 г. 17:27 ч., Johannes Thumshirn wrote: >> Hmm "... and num_added" for the Subject? > > Nah, that's obvious, the focus here is instead of taking 4-5 more > arguments they are replaced with async_cow. > Fair enough -- Johannes Thums

Re: [PATCH v2 3/6] btrfs: Make compress_file_range take only struct async_cow

2019-02-21 Thread Nikolay Borisov
On 20.02.19 г. 17:27 ч., Johannes Thumshirn wrote: > Hmm "... and num_added" for the Subject? Nah, that's obvious, the focus here is instead of taking 4-5 more arguments they are replaced with async_cow.

Re: [PATCH v2 3/6] btrfs: Make compress_file_range take only struct async_cow

2019-02-20 Thread Johannes Thumshirn
Hmm "... and num_added" for the Subject? -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürn

[PATCH v2 3/6] btrfs: Make compress_file_range take only struct async_cow

2019-02-20 Thread Nikolay Borisov
All context this function needs is held within struct async_cow. Currently we not only pass the struct but also every individual member. This is redundant, simplify it by only passing struct async_cow and leaving it to compress_file_range to extract the values it requires. No functional changes. S