Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-15 Thread Qu Wenruo
On 2017年09月15日 23:48, David Sterba wrote: On Fri, Sep 15, 2017 at 09:24:19PM +0800, Qu Wenruo wrote: I'm going to review & merge this series to devel. Tests and documentation should be updated to make the usecase clear. I'm happy to address any comment, both code and doc/test. For the test

Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-15 Thread David Sterba
On Fri, Sep 15, 2017 at 09:24:19PM +0800, Qu Wenruo wrote: > > I'm going to review & merge this series to devel. Tests and > > documentation should be updated to make the usecase clear. > > I'm happy to address any comment, both code and doc/test. For the tests I'd like to see: * with file targe

Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-15 Thread Qu Wenruo
On 2017年09月15日 20:56, David Sterba wrote: On Wed, Sep 13, 2017 at 08:32:50AM +0800, Qu Wenruo wrote: On 2017年09月13日 02:07, David Sterba wrote: On Tue, Sep 12, 2017 at 07:50:19PM +0200, Goffredo Baroncelli wrote: On 09/12/2017 07:03 PM, David Sterba wrote: Say I want to prepare a minimal ima

Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-15 Thread David Sterba
On Wed, Sep 13, 2017 at 08:32:50AM +0800, Qu Wenruo wrote: > On 2017年09月13日 02:07, David Sterba wrote: > > On Tue, Sep 12, 2017 at 07:50:19PM +0200, Goffredo Baroncelli wrote: > >> On 09/12/2017 07:03 PM, David Sterba wrote: > >>> Say I want to prepare a minimal image but will provide a large file

Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-12 Thread Qu Wenruo
On 2017年09月13日 02:07, David Sterba wrote: On Tue, Sep 12, 2017 at 07:50:19PM +0200, Goffredo Baroncelli wrote: On 09/12/2017 07:03 PM, David Sterba wrote: Say I want to prepare a minimal image but will provide a large file

Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-12 Thread David Sterba
On Tue, Sep 12, 2017 at 07:50:19PM +0200, Goffredo Baroncelli wrote: > On 09/12/2017 07:03 PM, David Sterba wrote: > > Say I want to prepare a minimal image but will provide a large file > ^^ > > I think that if the target is a f

Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-12 Thread Goffredo Baroncelli
On 09/12/2017 07:03 PM, David Sterba wrote: > Say I want to prepare a minimal image but will provide a large file ^^ I think that if the target is a file AND --minimize is passed, it is a reasonable expectation that the file is

Re: [PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-12 Thread David Sterba
On Mon, Sep 11, 2017 at 03:36:12PM +0900, Qu Wenruo wrote: > Add extra limitation explained for --rootdir option, including: > 1) Size limitation >Now I decide to follow "mkfs.ext4 -d" behavior, so we user is >responsible to make sure the block device/file is large enough. That's fine and

[PATCH v2 7/7] btrfs-progs: Doc/mkfs: Add extra condition for rootdir option

2017-09-10 Thread Qu Wenruo
Add extra limitation explained for --rootdir option, including: 1) Size limitation Now I decide to follow "mkfs.ext4 -d" behavior, so we user is responsible to make sure the block device/file is large enough. 2) Read permission If user can't read the content, mkfs will just fail. So us