Re: [PATCH v3] Btrfs: remove unused check of skip_locking

2018-05-29 Thread David Sterba
On Tue, May 29, 2018 at 09:27:06PM +0800, Liu Bo wrote: > The check is superfluous since all of callers who set search_for_commit > also have skip_locking set. > > ASSERT() is put in place to ensure skip_locking is set by callers. > > Reviewed-by: Qu Wenruo > Signed-off-by: Liu Bo Added to the

[PATCH v3] Btrfs: remove unused check of skip_locking

2018-05-29 Thread Liu Bo
The check is superfluous since all of callers who set search_for_commit also have skip_locking set. ASSERT() is put in place to ensure skip_locking is set by callers. Reviewed-by: Qu Wenruo Signed-off-by: Liu Bo --- v3: Add assertion and comments to ensure skip_locking is not forgot by callers.