Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-21 Thread Qu Wenruo
At 06/18/2017 09:42 PM, Adam Borowski wrote: On Sun, Jun 18, 2017 at 07:23:00PM +0800, Qu Wenruo wrote: [ 39.726215] BTRFS warning (device sda1): unhandled fiemap cache detected: offset=phys$35798867968 len1072 flags=0x2008 [ 151.882586] BTRFS warning (device sda1): unhandled fiemap cac

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-18 Thread Adam Borowski
On Sun, Jun 18, 2017 at 07:23:00PM +0800, Qu Wenruo wrote: > > > [ 39.726215] BTRFS warning (device sda1): unhandled fiemap cache > > > detected: offset=phys$35798867968 len1072 flags=0x2008 > > > [ 151.882586] BTRFS warning (device sda1): unhandled fiemap cache > > > detected: offset=phys$357

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-18 Thread Holger Hoffstätte
On 06/18/17 13:23, Qu Wenruo wrote: > Well, still no good news. > > I created file extents which returns 0x2008 and the last extent with 0x9. > But still failed to reproduce the error message. > > BTW, I noticed that your output is a little strange. > Normally we should have "offset=%llu phys=%ll

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-18 Thread Qu Wenruo
On 2017年06月18日 17:38, Qu Wenruo wrote: On 2017年06月18日 05:24, Adam Borowski wrote: On Sat, Jun 17, 2017 at 09:28:30PM +0800, Qu Wenruo wrote: I for one get this a lot even in regular use. Somehow, it always has Comm: dpkg, despite the vast majority of activity on the system obviously not b

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-18 Thread Qu Wenruo
On 2017年06月18日 05:24, Adam Borowski wrote: On Sat, Jun 17, 2017 at 09:28:30PM +0800, Qu Wenruo wrote: I for one get this a lot even in regular use. Somehow, it always has Comm: dpkg, despite the vast majority of activity on the system obviously not being dpkg. linus/master without any extr

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-17 Thread Adam Borowski
On Sat, Jun 17, 2017 at 09:28:30PM +0800, Qu Wenruo wrote: > > I for one get this a lot even in regular use. Somehow, it always has Comm: > > dpkg, despite the vast majority of activity on the system obviously not > > being dpkg. > linus/master without any extra patch is still the same? > And whi

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-17 Thread Adam Borowski
On Sat, Jun 17, 2017 at 09:28:30PM +0800, Qu Wenruo wrote: > On 2017年06月17日 16:30, Adam Borowski wrote: > > On Sat, Jun 17, 2017 at 03:43:18PM +0800, Qu Wenruo wrote: > > > On 2017年06月16日 20:33, David Sterba wrote: > > > > I see a lot of warnings from btrfs/094 > > > > > > > > [13458.628334] BTRFS

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-17 Thread Qu Wenruo
On 2017年06月17日 16:30, Adam Borowski wrote: On Sat, Jun 17, 2017 at 03:43:18PM +0800, Qu Wenruo wrote: On 2017年06月16日 20:33, David Sterba wrote: I see a lot of warnings from btrfs/094 [13458.628334] BTRFS warning (device sdb6): unhandled fiemap cache detected: offset=581632 phys=13078528 len

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-17 Thread Adam Borowski
On Sat, Jun 17, 2017 at 03:43:18PM +0800, Qu Wenruo wrote: > On 2017年06月16日 20:33, David Sterba wrote: > > I see a lot of warnings from btrfs/094 > > > > [13458.628334] BTRFS warning (device sdb6): unhandled fiemap cache > > detected: offset=581632 phys=13078528 len=4096 flags=0x800 > > Strangel

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-17 Thread Qu Wenruo
On 2017年06月16日 20:33, David Sterba wrote: On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: fs/btrfs/extent_io.c | 124 ++- 1 file changed, 122 insertions(+), 2 deletions(-) I see a lot of warnings from btrfs/094 [13458.628334] BTR

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-06-16 Thread David Sterba
On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: > fs/btrfs/extent_io.c | 124 > ++- > 1 file changed, 122 insertions(+), 2 deletions(-) I see a lot of warnings from btrfs/094 [13458.628334] BTRFS warning (device sdb6): unhandled fiemap

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-05-05 Thread David Sterba
On Thu, Apr 13, 2017 at 08:36:24AM +0800, Qu Wenruo wrote: > > > At 04/12/2017 11:05 PM, David Sterba wrote: > > On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: > >> [BUG] > >> Cycle mount btrfs can cause fiemap to return different result. > >> Like: > >> # mount /dev/vdb5 /mnt/btrfs

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-05-05 Thread David Sterba
On Thu, Apr 20, 2017 at 12:52:55PM -0700, Liu Bo wrote: > On Thu, Apr 20, 2017 at 10:09:39AM +0800, Qu Wenruo wrote: > > > > > > At 04/20/2017 09:58 AM, Liu Bo wrote: > > > On Thu, Apr 20, 2017 at 09:52:00AM +0800, Qu Wenruo wrote: > > > > > > > > > [...] > > > > > > > > > > If I understand it

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-05-05 Thread David Sterba
On Thu, Apr 20, 2017 at 10:09:39AM +0800, Qu Wenruo wrote: > >>> If I understand it correctly, what it's missing currently is 'merge', a > >>> straightfoward idea is to make use of the 'merge' ability of > >>> btrfs_get_extent. > > >>> Since btrfs_get_extent_fiemap is a wrapper of btrfs_get_extent

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-20 Thread Liu Bo
On Thu, Apr 20, 2017 at 10:09:39AM +0800, Qu Wenruo wrote: > > > At 04/20/2017 09:58 AM, Liu Bo wrote: > > On Thu, Apr 20, 2017 at 09:52:00AM +0800, Qu Wenruo wrote: > > > > > > [...] > > > > > > > > If I understand it correctly, what it's missing currently is 'merge', a > > > > straightfoward

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-19 Thread Qu Wenruo
At 04/20/2017 10:08 AM, Liu Bo wrote: On Thu, Apr 20, 2017 at 09:52:00AM +0800, Qu Wenruo wrote: At 04/20/2017 09:25 AM, Liu Bo wrote: On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: [BUG] Cycle mount btrfs can cause fiemap to return different result. Like: # mount /dev/vdb5

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-19 Thread Qu Wenruo
At 04/20/2017 09:58 AM, Liu Bo wrote: On Thu, Apr 20, 2017 at 09:52:00AM +0800, Qu Wenruo wrote: At 04/20/2017 09:25 AM, Liu Bo wrote: On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: [BUG] Cycle mount btrfs can cause fiemap to return different result. Like: # mount /dev/vdb5

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-19 Thread Liu Bo
On Thu, Apr 20, 2017 at 09:52:00AM +0800, Qu Wenruo wrote: > > > At 04/20/2017 09:25 AM, Liu Bo wrote: > > On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: > > > [BUG] > > > Cycle mount btrfs can cause fiemap to return different result. > > > Like: > > > # mount /dev/vdb5 /mnt/btrfs >

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-19 Thread Liu Bo
On Thu, Apr 20, 2017 at 09:52:00AM +0800, Qu Wenruo wrote: > > > At 04/20/2017 09:25 AM, Liu Bo wrote: > > On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: > > > [BUG] > > > Cycle mount btrfs can cause fiemap to return different result. > > > Like: > > > # mount /dev/vdb5 /mnt/btrfs >

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-19 Thread Qu Wenruo
At 04/20/2017 09:25 AM, Liu Bo wrote: On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: [BUG] Cycle mount btrfs can cause fiemap to return different result. Like: # mount /dev/vdb5 /mnt/btrfs # dd if=/dev/zero bs=16K count=4 oflag=dsync of=/mnt/btrfs/file # xfs_io -c "fiemap -v"

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-19 Thread Liu Bo
On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: > [BUG] > Cycle mount btrfs can cause fiemap to return different result. > Like: > # mount /dev/vdb5 /mnt/btrfs > # dd if=/dev/zero bs=16K count=4 oflag=dsync of=/mnt/btrfs/file > # xfs_io -c "fiemap -v" /mnt/btrfs/file > /mnt/test/file

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-12 Thread Qu Wenruo
At 04/12/2017 11:05 PM, David Sterba wrote: On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: [BUG] Cycle mount btrfs can cause fiemap to return different result. Like: # mount /dev/vdb5 /mnt/btrfs # dd if=/dev/zero bs=16K count=4 oflag=dsync of=/mnt/btrfs/file # xfs_io -c "fiem

Re: [PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-12 Thread David Sterba
On Fri, Apr 07, 2017 at 10:43:15AM +0800, Qu Wenruo wrote: > [BUG] > Cycle mount btrfs can cause fiemap to return different result. > Like: > # mount /dev/vdb5 /mnt/btrfs > # dd if=/dev/zero bs=16K count=4 oflag=dsync of=/mnt/btrfs/file > # xfs_io -c "fiemap -v" /mnt/btrfs/file > /mnt/test/file

[PATCH v3] btrfs: fiemap: Cache and merge fiemap extent before submit it to user

2017-04-06 Thread Qu Wenruo
[BUG] Cycle mount btrfs can cause fiemap to return different result. Like: # mount /dev/vdb5 /mnt/btrfs # dd if=/dev/zero bs=16K count=4 oflag=dsync of=/mnt/btrfs/file # xfs_io -c "fiemap -v" /mnt/btrfs/file /mnt/test/file: EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..127]: