Re: [PATCH v3] btrfs-progs: mkfs: Enable -d dup for single device

2015-11-26 Thread David Sterba
On Thu, Nov 19, 2015 at 04:14:16PM -0500, Austin S Hemmelgarn wrote: > On 2015-11-19 04:36, Zhao Lei wrote: > > Signed-off-by: Zhao Lei > Seeing as I forgot to reply to the previous version after testing it, > I'll just reply here now that I've run this version through

[PATCH v3] btrfs-progs: mkfs: Enable -d dup for single device

2015-11-19 Thread Zhao Lei
Current code don't support dup profile in single device, except it is in mixed mode, because following reason: 1: In some ssd with deduplication function, it have no effect. 2: For a physical device, it the entire disk broken, -d dup can not help. 3: Half performance comparing with single

Re: [PATCH v3] btrfs-progs: mkfs: Enable -d dup for single device

2015-11-19 Thread Austin S Hemmelgarn
On 2015-11-19 04:36, Zhao Lei wrote: Current code don't support dup profile in single device, except it is in mixed mode, because following reason: 1: In some ssd with deduplication function, it have no effect. 2: For a physical device, it the entire disk broken, -d dup can not help. 3: Half