Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails

2017-04-24 Thread Ross Zwisler
On Mon, Apr 24, 2017 at 09:22:45AM -0400, Jeff Layton wrote: > In order to get proper error codes from fsync, we must set an error in > the mapping range when writeback fails. > > Signed-off-by: Jeff Layton Works fine in some error injection testing. Tested-by: Ross Zwisler > --- > fs/dax.c

Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails

2017-04-24 Thread Jan Kara
On Mon 24-04-17 09:22:45, Jeff Layton wrote: > In order to get proper error codes from fsync, we must set an error in > the mapping range when writeback fails. > > Signed-off-by: Jeff Layton So I'm fine with the change but please expand the changelog to something like: DAX currently doesn't set

Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails

2017-04-24 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3 06/20] dax: set errors in mapping when writeback fails

2017-04-24 Thread Jeff Layton
In order to get proper error codes from fsync, we must set an error in the mapping range when writeback fails. Signed-off-by: Jeff Layton --- fs/dax.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index 85abd741253d..9b6b04030c3f 100644 --- a/fs/dax.c