Re: [PATCH v3 1/2] btrfs: Add support to do stack item key operation

2015-10-14 Thread Qu Wenruo
Hi David, Any further comment? Thanks, Qu Qu Wenruo wrote on 2015/10/07 09:22 +0800: Hi David, I'm sorry that I didn't get the point of your previous comment. Maybe the parameter/function name don't follow BTRFS_STACK_GETSET_FUNC macro, but IMHO that's OK, as btrfs_item_key_to_cpu() is not a

Re: [PATCH v3 1/2] btrfs: Add support to do stack item key operation

2015-10-06 Thread Qu Wenruo
Hi David, I'm sorry that I didn't get the point of your previous comment. Maybe the parameter/function name don't follow BTRFS_STACK_GETSET_FUNC macro, but IMHO that's OK, as btrfs_item_key_to_cpu() is not an accessor following that macro definition. It's called even before we get needed data

[PATCH v3 1/2] btrfs: Add support to do stack item key operation

2015-10-06 Thread Qu Wenruo
Normal btrfs_item_key_to_cpu() will need extent buffer to do it, and there is not stack version to handle in memory leaf. Add btrfs_stack_item_key_to_cpu() function for such operation, which will provide the basis for later qgroup fix. Signed-off-by: Qu Wenruo --- v2: Change the char* paramete