Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-24 Thread Anand Jain
On 05/25/2018 10:59 AM, Qu Wenruo wrote: On 2018年05月25日 08:54, Qu Wenruo wrote: On 2018年05月25日 00:24, Anand Jain wrote: On misc-next this patch is causing regression, the seed sprout functionality test [1] (in the mailing list) fails.  [1]  [PATCH] fstests: btrfs: add seed sprout

Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-24 Thread Qu Wenruo
On 2018年05月25日 08:54, Qu Wenruo wrote: > > > On 2018年05月25日 00:24, Anand Jain wrote: >> >> >> On misc-next this patch is causing regression, the seed sprout >> functionality test [1] (in the mailing list) fails. >> >>  [1] >>  [PATCH] fstests: btrfs: add seed sprout functionality test >> >>

Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-24 Thread Qu Wenruo
On 2018年05月25日 00:24, Anand Jain wrote: > > > On misc-next this patch is causing regression, the seed sprout > functionality test [1] (in the mailing list) fails. > >  [1] >  [PATCH] fstests: btrfs: add seed sprout functionality test > > more below.. > > On 05/11/2018 01:35 PM, Qu Wenruo

Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-24 Thread David Sterba
On Fri, May 25, 2018 at 12:24:10AM +0800, Anand Jain wrote: > On misc-next this patch is causing regression, the seed sprout > functionality test [1] (in the mailing list) fails. This patch merly moves the function so it must have been broken before that already. > > + if

Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-24 Thread Anand Jain
On misc-next this patch is causing regression, the seed sprout functionality test [1] (in the mailing list) fails. [1] [PATCH] fstests: btrfs: add seed sprout functionality test more below.. On 05/11/2018 01:35 PM, Qu Wenruo wrote: Just move btrfs_check_super_valid() before its single

Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-11 Thread David Sterba
On Fri, May 11, 2018 at 11:36:54AM +0200, David Sterba wrote: > On Fri, May 11, 2018 at 01:35:25PM +0800, Qu Wenruo wrote: > > Just move btrfs_check_super_valid() before its single caller to avoid > > forward declaration. > > Please don't move functions just to get rid of the forward

Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-11 Thread David Sterba
On Fri, May 11, 2018 at 01:35:25PM +0800, Qu Wenruo wrote: > Just move btrfs_check_super_valid() before its single caller to avoid > forward declaration. Please don't move functions just to get rid of the forward declarations. Moving functions to make them static or if they're in a wrong .c is

[PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

2018-05-10 Thread Qu Wenruo
Just move btrfs_check_super_valid() before its single caller to avoid forward declaration. Signed-off-by: Qu Wenruo --- fs/btrfs/disk-io.c | 299 ++--- 1 file changed, 149 insertions(+), 150 deletions(-) diff --git a/fs/btrfs/disk-io.c