Re: [PATCH v3 2/2] btrfs: Remove received_uuid during received snapshot ro->rw switch

2017-10-04 Thread David Sterba
On Fri, Sep 29, 2017 at 10:15:30PM +0300, Nikolay Borisov wrote: > > Adding the transaction before the "if (flags & BTRFS_SUBVOL_RDONLY)" > > condition makes it much worse. The "is subvolume in send" test is > > supposed to be lightweight and should not shoot down the whole > > filesystem. The usec

Re: [PATCH v3 2/2] btrfs: Remove received_uuid during received snapshot ro->rw switch

2017-09-29 Thread Nikolay Borisov
On 29.09.2017 20:56, David Sterba wrote: > On Thu, Sep 28, 2017 at 10:53:18AM +0300, Nikolay Borisov wrote: >> Currently when a read-only snapshot is received and subsequently its ro >> property >> is set to false i.e. switched to rw-mode the received_uuid of that subvol >> remains >> intact. H

Re: [PATCH v3 2/2] btrfs: Remove received_uuid during received snapshot ro->rw switch

2017-09-29 Thread David Sterba
On Thu, Sep 28, 2017 at 10:53:18AM +0300, Nikolay Borisov wrote: > Currently when a read-only snapshot is received and subsequently its ro > property > is set to false i.e. switched to rw-mode the received_uuid of that subvol > remains > intact. However, once the received volume is switched to RW

[PATCH v3 2/2] btrfs: Remove received_uuid during received snapshot ro->rw switch

2017-09-28 Thread Nikolay Borisov
Currently when a read-only snapshot is received and subsequently its ro property is set to false i.e. switched to rw-mode the received_uuid of that subvol remains intact. However, once the received volume is switched to RW mode we cannot guaranteee that it contains the same data, so it makes sense