Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-25 Thread Bagas Sanjaya
On Thu, Oct 17, 2024 at 03:57:50PM -0500, Ira Weiny wrote: > Bagas Sanjaya wrote: > > On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > > > +Struct Range > > > + > > > + > > > +:: > > > + > > > + %pra[range 0x6000-0x6fff] > > > + %pra[range 0x0

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-17 Thread Ira Weiny
Bagas Sanjaya wrote: > On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > > +Struct Range > > + > > + > > +:: > > + > > + %pra[range 0x6000-0x6fff] > > + %pra[range 0x6000] > > + > > +For printing struct range. struct range hold

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-13 Thread Ira Weiny
Andy Shevchenko wrote: > On Wed, Oct 09, 2024 at 03:30:14PM +0200, Rasmus Villemoes wrote: > > ... > > > Rather than the struct assignments, I think it's easier to read if you > > just do > > > > struct range r; > > > > r.start = 0xc0ffee00ba5eba11; > > r.end = r.start; > > ... > > >

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-11 Thread Ira Weiny
Rasmus Villemoes wrote: > Ira Weiny writes: > > > --- > > Documentation/core-api/printk-formats.rst | 13 > > lib/test_printf.c | 26 +++ > > lib/vsprintf.c| 55 > > +++ > > 3 files changed, 88

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-10 Thread Bagas Sanjaya
On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > +Struct Range > + > + > +:: > + > + %pra[range 0x6000-0x6fff] > + %pra[range 0x6000] > + > +For printing struct range. struct range holds an arbitrary range of u64 > +values

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > The use of struct range in the CXL subsystem is growing. In particular, > the addition of Dynamic Capacity devices uses struct range in a number > of places which are reported in debug and error messages. > > To wit requiring the printi

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 01:27:37PM +0100, Jonathan Cameron wrote: > On Tue, 8 Oct 2024 19:56:20 +0300 > Andy Shevchenko wrote: > > On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: ... > > > +static void __init > > > +struct_range(void) > > > +{ > > > + struct range test_range = { > > >

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 03:30:14PM +0200, Rasmus Villemoes wrote: ... > Rather than the struct assignments, I think it's easier to read if you > just do > > struct range r; > > r.start = 0xc0ffee00ba5eba11; > r.end = r.start; > ... > > r.start = 0xc0ffee; > r.end = 0xba5eba11;

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Rasmus Villemoes
Ira Weiny writes: > --- > Documentation/core-api/printk-formats.rst | 13 > lib/test_printf.c | 26 +++ > lib/vsprintf.c| 55 > +++ > 3 files changed, 88 insertions(+), 6 deletions(-) > > diff -

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Jonathan Cameron
On Tue, 8 Oct 2024 19:56:20 +0300 Andy Shevchenko wrote: > On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > > The use of struct range in the CXL subsystem is growing. In particular, > > the addition of Dynamic Capacity devices uses struct range in a number > > of places which are rep

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-08 Thread Andy Shevchenko
On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > The use of struct range in the CXL subsystem is growing. In particular, > the addition of Dynamic Capacity devices uses struct range in a number > of places which are reported in debug and error messages. > > To wit requiring the printi

[PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-07 Thread Ira Weiny
The use of struct range in the CXL subsystem is growing. In particular, the addition of Dynamic Capacity devices uses struct range in a number of places which are reported in debug and error messages. To wit requiring the printing of the start/end fields in each print became cumbersome. Dan Will