Re: [PATCH v4 1/3] btrfs: scrub: fix circular locking dependency warning

2019-02-13 Thread Anand Jain
On 2/13/19 12:45 AM, David Sterba wrote: On Wed, Jan 30, 2019 at 02:45:00PM +0800, Anand Jain wrote: Circular locking dependency check reports warning[1], that's because the btrfs_scrub_dev() calls the stack #0 below with, the fs_info::scrub_lock held. The test case leading to this warning..

Re: [PATCH v4 1/3] btrfs: scrub: fix circular locking dependency warning

2019-02-12 Thread David Sterba
On Wed, Jan 30, 2019 at 02:45:00PM +0800, Anand Jain wrote: > Circular locking dependency check reports warning[1], that's because > the btrfs_scrub_dev() calls the stack #0 below with, the > fs_info::scrub_lock held. The test case leading to this warning.. > > mkfs.btrfs -fq /dev/sdb && mount /

Re: [PATCH v4 1/3] btrfs: scrub: fix circular locking dependency warning

2019-02-12 Thread David Sterba
On Thu, Jan 31, 2019 at 02:34:54PM +0800, Anand Jain wrote: > > > On 1/30/19 10:07 PM, David Sterba wrote: > > On Wed, Jan 30, 2019 at 02:45:00PM +0800, Anand Jain wrote: > >> v3->v4: Fix list corruption as reported by btrfs/073 by David. > >> [1] > >> https://patchwork.ke

Re: [PATCH v4 1/3] btrfs: scrub: fix circular locking dependency warning

2019-01-30 Thread Anand Jain
On 1/30/19 10:07 PM, David Sterba wrote: On Wed, Jan 30, 2019 at 02:45:00PM +0800, Anand Jain wrote: v3->v4: Fix list corruption as reported by btrfs/073 by David. [1] https://patchwork.kernel.org/patch/10705741/ Which I was able to reproduce with an instrument

Re: [PATCH v4 1/3] btrfs: scrub: fix circular locking dependency warning

2019-01-30 Thread David Sterba
On Wed, Jan 30, 2019 at 02:45:00PM +0800, Anand Jain wrote: > v3->v4: Fix list corruption as reported by btrfs/073 by David. >[1] >https://patchwork.kernel.org/patch/10705741/ > Which I was able to reproduce with an instrumented kernel but not with > btrfs/073. >

[PATCH v4 1/3] btrfs: scrub: fix circular locking dependency warning

2019-01-29 Thread Anand Jain
Circular locking dependency check reports warning[1], that's because the btrfs_scrub_dev() calls the stack #0 below with, the fs_info::scrub_lock held. The test case leading to this warning.. mkfs.btrfs -fq /dev/sdb && mount /dev/sdb /btrfs btrfs scrub start -B /btrfs In fact we have fs_info: