Re: [PATCH v5 06/78] xarray: Change definition of sibling entries

2017-12-27 Thread Kirill A. Shutemov
On Tue, Dec 26, 2017 at 07:13:26PM -0800, Matthew Wilcox wrote: > On Tue, Dec 26, 2017 at 08:21:53PM +0300, Kirill A. Shutemov wrote: > > > +/** > > > + * xa_is_internal() - Is the entry an internal entry? > > > + * @entry: Entry retrieved from the XArray > > > + * > > > + * Return: %true if the en

Re: [PATCH v5 06/78] xarray: Change definition of sibling entries

2017-12-26 Thread Matthew Wilcox
On Tue, Dec 26, 2017 at 08:21:53PM +0300, Kirill A. Shutemov wrote: > > +/** > > + * xa_is_internal() - Is the entry an internal entry? > > + * @entry: Entry retrieved from the XArray > > + * > > + * Return: %true if the entry is an internal entry. > > + */ > > What does it mean "internal entry"?

Re: [PATCH v5 06/78] xarray: Change definition of sibling entries

2017-12-26 Thread Kirill A. Shutemov
On Fri, Dec 15, 2017 at 02:03:38PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > Instead of storing a pointer to the slot containing the canonical entry, > store the offset of the slot. Produces slightly more efficient code > (~300 bytes) and simplifies the implementation. > > Signed-

[PATCH v5 06/78] xarray: Change definition of sibling entries

2017-12-15 Thread Matthew Wilcox
From: Matthew Wilcox Instead of storing a pointer to the slot containing the canonical entry, store the offset of the slot. Produces slightly more efficient code (~300 bytes) and simplifies the implementation. Signed-off-by: Matthew Wilcox --- include/linux/xarray.h | 82 +