Re: [PATCH v5 4/6] Btrfs: heuristic add detection of zeroed sample

2017-08-23 Thread Timofey Titovets
2017-08-23 20:55 GMT+03:00 Diego Calleja : > El miércoles, 23 de agosto de 2017 2:26:48 (CEST) Timofey Titovets escribió: >> + for (i = 0; i < workspace->sample_size; i += sizeof(zero)) { >> + if (memcmp(>sample[i], , sizeof(zero))) >> +

Re: [PATCH v5 4/6] Btrfs: heuristic add detection of zeroed sample

2017-08-23 Thread Diego Calleja
El miércoles, 23 de agosto de 2017 2:26:48 (CEST) Timofey Titovets escribió: > + for (i = 0; i < workspace->sample_size; i += sizeof(zero)) { > + if (memcmp(>sample[i], , sizeof(zero))) > + return false; Instead of just checking for 0, wouldn't it be a better

[PATCH v5 4/6] Btrfs: heuristic add detection of zeroed sample

2017-08-22 Thread Timofey Titovets
Use memcmp for check sample data to zeroes. Signed-off-by: Timofey Titovets --- fs/btrfs/heuristic.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/fs/btrfs/heuristic.c b/fs/btrfs/heuristic.c index 5336638a3b7c..4557ea1db373 100644 ---