Re: [PATCH v7 0/4] VFS: In-kernel copy system call

On Sat, Oct 24, 2015 at 11:52:37AM -0500, Eric Biggers wrote: > A few comments: > > > if (!(file_in->f_mode & FMODE_READ) || > > !(file_out->f_mode & FMODE_WRITE) || > > (file_out->f_flags & O_APPEND) || > > !file_out->f_op) > > return -EBADF; >

Re: [PATCH v7 0/4] VFS: In-kernel copy system call

A few comments: > if (!(file_in->f_mode & FMODE_READ) || > !(file_out->f_mode & FMODE_WRITE) || > (file_out->f_flags & O_APPEND) || > !file_out->f_op) > return -EBADF; Isn't 'f_op' always non-NULL? If the destination file cannot be append-only,

Re: [PATCH v7 0/4] VFS: In-kernel copy system call

> On Oct 24, 2015, at 10:52 AM, Eric Biggers wrote: > > A few comments: > >> if (!(file_in->f_mode & FMODE_READ) || >> !(file_out->f_mode & FMODE_WRITE) || >> (file_out->f_flags & O_APPEND) || >> !file_out->f_op) >> return

Re: [PATCH v7 0/4] VFS: In-kernel copy system call

Thanks Anna, the whole series looks good to me, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v7 0/4] VFS: In-kernel copy system call

Copy system calls came up during Plumbers a while ago, mostly because several filesystems (including NFS and XFS) are currently working on copy acceleration implementations. We haven't heard from Zach Brown in a while, so I volunteered to push his patches upstream so individual filesystems don't