Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Nicholas D Steeves wrote on 2016/04/22 18:14 -0400: Hi Qu, On 6 April 2016 at 01:22, Qu Wenruo wrote: Nicholas D Steeves wrote on 2016/04/05 23:47 -0400: It is unlikely that I will use dedupe, but I imagine your work will apply tot he following wishlist: 1.

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Hi Qu, On 6 April 2016 at 01:22, Qu Wenruo wrote: > > > Nicholas D Steeves wrote on 2016/04/05 23:47 -0400: >> >> It is unlikely that I will use dedupe, but I imagine your work will >> apply tot he following wishlist: >> >> 1. Allow disabling of memory-backend hash via a

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

On Wed, Apr 20, 2016 at 10:02:27AM +0800, Qu Wenruo wrote: > Hi David, > > Any new comment about the ondisk format and ioctl interface? Hi Qu, I'm at LSF this week but will dig through again on the way home. Thanks! -chris -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Hi David, Any new comment about the ondisk format and ioctl interface? Thanks, Qu Qu Wenruo wrote on 2016/04/05 11:08 +0800: David Sterba wrote on 2016/04/04 18:55 +0200: On Fri, Mar 25, 2016 at 09:38:50AM +0800, Qu Wenruo wrote: Please use the newly added BTRFS_PERSISTENT_ITEM_KEY

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Nicholas D Steeves wrote on 2016/04/05 23:47 -0400: On 4 April 2016 at 12:55, David Sterba wrote: Not exactly. If we are using unsafe hash, e.g MD5, we will use MD5 only for both in-memory and on-disk backend. No SHA256 again. I'm proposing unsafe but fast, which MD5 is

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

On 4 April 2016 at 12:55, David Sterba wrote: >> >> Not exactly. If we are using unsafe hash, e.g MD5, we will use MD5 only >> >> for both in-memory and on-disk backend. No SHA256 again. >> > >> > I'm proposing unsafe but fast, which MD5 is not. Look for xxhash or >> > murmur. As

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Alex Lyakas wrote on 2016/04/03 10:22 +0200: Hello Qu, Wang, On Wed, Mar 30, 2016 at 2:34 AM, Qu Wenruo wrote: Alex Lyakas wrote on 2016/03/29 19:22 +0200: Greetings Qu Wenruo, I have reviewed the dedup patchset found in the github account you mentioned. I have

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

David Sterba wrote on 2016/04/04 18:55 +0200: On Fri, Mar 25, 2016 at 09:38:50AM +0800, Qu Wenruo wrote: Please use the newly added BTRFS_PERSISTENT_ITEM_KEY instead of a new key type. As this is the second user of that item, there's no precendent how to select the subtype. Right now 0 is for

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

On Fri, Mar 25, 2016 at 09:38:50AM +0800, Qu Wenruo wrote: > > Please use the newly added BTRFS_PERSISTENT_ITEM_KEY instead of a new > > key type. As this is the second user of that item, there's no precendent > > how to select the subtype. Right now 0 is for the dev stats item, but > > I'd like

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Hello Qu, Wang, On Wed, Mar 30, 2016 at 2:34 AM, Qu Wenruo wrote: > > > Alex Lyakas wrote on 2016/03/29 19:22 +0200: >> >> Greetings Qu Wenruo, >> >> I have reviewed the dedup patchset found in the github account you >> mentioned. I have several questions. Please note

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Thanks for your comments, Qu. Alex. On Wed, Mar 30, 2016 at 2:34 AM, Qu Wenruo wrote: > > > Alex Lyakas wrote on 2016/03/29 19:22 +0200: >> >> Greetings Qu Wenruo, >> >> I have reviewed the dedup patchset found in the github account you >> mentioned. I have several

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Alex Lyakas wrote on 2016/03/29 19:22 +0200: Greetings Qu Wenruo, I have reviewed the dedup patchset found in the github account you mentioned. I have several questions. Please note that by all means I am not criticizing your design or code. I just want to make sure that my understanding of

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Greetings Qu Wenruo, I have reviewed the dedup patchset found in the github account you mentioned. I have several questions. Please note that by all means I am not criticizing your design or code. I just want to make sure that my understanding of the code is proper. 1) You mentioned in several

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

David Sterba wrote on 2016/03/24 14:42 +0100: On Wed, Mar 23, 2016 at 10:25:51AM +0800, Qu Wenruo wrote: Thank you for your interest in dedupe patchset first. In fact I'm quite afraid if there is no one interest in the patchset, it may be delayed again to 4.8. It's not about lack of

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

On Wed, Mar 23, 2016 at 10:25:51AM +0800, Qu Wenruo wrote: > Thank you for your interest in dedupe patchset first. > > In fact I'm quite afraid if there is no one interest in the patchset, it > may be delayed again to 4.8. It's not about lack of interest, the high-profile features need time and

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Thank you for your interest in dedupe patchset first. In fact I'm quite afraid if there is no one interest in the patchset, it may be delayed again to 4.8. David Sterba wrote on 2016/03/22 14:38 +0100: On Tue, Mar 22, 2016 at 09:35:25AM +0800, Qu Wenruo wrote: This updated version of inband

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

On Tue, Mar 22, 2016 at 09:35:25AM +0800, Qu Wenruo wrote: > This updated version of inband de-duplication has the following features: > 1) ONE unified dedup framework. > 2) TWO different back-end with different trade-off The on-disk format is defined in code, would be good to give some overview

[PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

This patchset can be fetched from github: https://github.com/adam900710/linux.git wang_dedupe_20160322 This updated version of inband de-duplication has the following features: 1) ONE unified dedup framework. Most of its code is hidden quietly in dedup.c and export the minimal interfaces