Re: [PATCH v8 16/18] ext4: use errseq_t based error handling for reporting data writeback errors

2017-06-29 Thread Jeff Layton
On Thu, 2017-06-29 at 07:12 -0700, Christoph Hellwig wrote: > > - if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb > > - return -EIO; > > + if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb { > > + ret = -EIO; > > + goto out; > > + } > > This ju

Re: [PATCH v8 16/18] ext4: use errseq_t based error handling for reporting data writeback errors

2017-06-29 Thread Christoph Hellwig
> - if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb > - return -EIO; > + if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb { > + ret = -EIO; > + goto out; > + } This just seems to add a call to trace_ext4_sync_file_exit for this cas

[PATCH v8 16/18] ext4: use errseq_t based error handling for reporting data writeback errors

2017-06-29 Thread jlayton
From: Jeff Layton Add a call to filemap_report_wb_err at the end of ext4_sync_file. This will ensure that we check and advance the errseq_t in the file, which allows us to track and report errors on all open fds when they occur. Note that metadata writeback errors are not yet reported on all fds