Hugo Mills wrote:
diff --git a/mkfs.c b/mkfs.c
index 03239fb..4aff2fd 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -63,7 +63,7 @@ static u64 parse_size(char *s)
s = strdup(s);
-if (!isdigit(s[len - 1])) {
+if (len !isdigit(s[len - 1])) {
I think I'd prefer that len is a size_t,
On Fri, Apr 20, 2012 at 09:27:26PM +0200, Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
* mkfs.c (parse_size): ./mkfs.btrfs -A '' would read and possibly
write the byte before beginning of strdup'd heap buffer. All other
size-accepting options were similarly affected.
From: Jim Meyering meyer...@redhat.com
* mkfs.c (parse_size): ./mkfs.btrfs -A '' would read and possibly
write the byte before beginning of strdup'd heap buffer. All other
size-accepting options were similarly affected.
Reviewed-by: Josef Bacik jo...@redhat.com
---
cmds-subvolume.c |2 +-
