[PATCh v2 2/9] btrfs: tree-checker: Make chunk item checker more readable

2019-03-19 Thread Qu Wenruo
Old error message would be something like: BTRFS error (device dm-3): invalid chunk num_stipres: 0 New error message would be: Btrfs critical (device dm-3): corrupt superblock syschunk array: chunk_start=2097152, invalid chunk num_stripes: 0 Or Btrfs critical (device dm-3): corrupt leaf: ro

Re: [PATCh v2 2/9] btrfs: tree-checker: Make chunk item checker more readable

2019-03-20 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn Although I think it would've been worth to explicitly mention that you increased the severity level from error to critical. -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 91

Re: [PATCh v2 2/9] btrfs: tree-checker: Make chunk item checker more readable

2019-03-26 Thread David Sterba
On Wed, Mar 20, 2019 at 11:41:44AM +0100, Johannes Thumshirn wrote: > Looks good, > Reviewed-by: Johannes Thumshirn > > Although I think it would've been worth to explicitly mention that you > increased the severity level from error to critical. Agreed, changelog updated.