Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-09 Thread David Sterba
On Fri, Dec 05, 2014 at 04:01:37PM +, Dimitri John Ledkov wrote: The other suggestion I received is to ship a systemd unit that does unconditional btrfs scan pre local filesystem target... =) While this works (as any ohter user script/hook that preceeds local filesystem mount), I'd rather

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-09 Thread David Sterba
On Fri, Dec 05, 2014 at 01:43:35PM -0500, Chris Mason wrote: I have the following reasons to support a mount.btrfs helper: 1) it is in a good point to check that everything is ok (see the thread related LVM snapshot, due to a dev.uuid conflicts), 2) it is in a good point to issue a good

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-09 Thread David Sterba
On Fri, Dec 05, 2014 at 08:51:51PM +0100, Goffredo Baroncelli wrote: From there if we really need a mount helper, it can either use a libbtrfs to hit the scan code or be a bash script. Thanks for trying to smooth our or wrinkles in this area. It's definitely worth working on, I just

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-05 Thread Chris Mason
On Sun, Nov 30, 2014 at 5:57 PM, Dimitri John Ledkov x...@debian.org wrote: On 30 November 2014 at 22:31, cwillu cwi...@cwillu.com wrote: In ubuntu, the initfs runs a btrfs dev scan, which should catch anything that would be missed there. I'm sorry, udev rule(s) is not sufficient in the

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-05 Thread Dimitri John Ledkov
On 5 December 2014 at 15:32, Chris Mason c...@fb.com wrote: On Sun, Nov 30, 2014 at 5:57 PM, Dimitri John Ledkov x...@debian.org wrote: On 30 November 2014 at 22:31, cwillu cwi...@cwillu.com wrote: In ubuntu, the initfs runs a btrfs dev scan, which should catch anything that would be

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-05 Thread David Sterba
On Fri, Dec 05, 2014 at 04:01:37PM +, Dimitri John Ledkov wrote: On 5 December 2014 at 15:32, Chris Mason c...@fb.com wrote: On Sun, Nov 30, 2014 at 5:57 PM, Dimitri John Ledkov x...@debian.org wrote: On 30 November 2014 at 22:31, cwillu cwi...@cwillu.com wrote: In ubuntu, the

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-05 Thread Goffredo Baroncelli
On 12/05/2014 05:41 PM, David Sterba wrote: We're looking for good reasons to justify the existence of the helper, but this is still not enough IMHO. I can see the convenience to do it automatically, but this assumes no udev available which is probably rare these days. I have the following

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-05 Thread Chris Mason
On Fri, Dec 5, 2014 at 1:15 PM, Goffredo Baroncelli kreij...@inwind.it wrote: On 12/05/2014 05:41 PM, David Sterba wrote: We're looking for good reasons to justify the existence of the helper, but this is still not enough IMHO. I can see the convenience to do it automatically, but this

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-05 Thread Goffredo Baroncelli
Hi Chris, On 12/05/2014 07:43 PM, Chris Mason wrote: On Fri, Dec 5, 2014 at 1:15 PM, Goffredo Baroncelli kreij...@inwind.it wrote: On 12/05/2014 05:41 PM, David Sterba wrote: We're looking for good reasons to justify the existence of the helper, but this is still not enough IMHO. I can

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-04 Thread Goffredo Baroncelli
On 12/04/2014 03:09 AM, Anand Jain wrote: On 01/12/2014 01:43, Goffredo Baroncelli wrote: Hi all, this patch provides a mount.btrfs helper for the mount command. A btrfs filesystem could span several disks. This helper scans all the partitions to discover all the disks required to mount

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-04 Thread Anand Jain
On 05/12/2014 01:58, Goffredo Baroncelli wrote: On 12/04/2014 03:09 AM, Anand Jain wrote: On 01/12/2014 01:43, Goffredo Baroncelli wrote: Hi all, this patch provides a mount.btrfs helper for the mount command. A btrfs filesystem could span several disks. This helper scans all the

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-03 Thread Anand Jain
On 01/12/2014 01:43, Goffredo Baroncelli wrote: Hi all, this patch provides a mount.btrfs helper for the mount command. A btrfs filesystem could span several disks. This helper scans all the partitions to discover all the disks required to mount a filesystem. So it would not necessary

[RFC][PATCH v2] mount.btrfs helper

2014-11-30 Thread Goffredo Baroncelli
Hi all, this patch provides a mount.btrfs helper for the mount command. A btrfs filesystem could span several disks. This helper scans all the partitions to discover all the disks required to mount a filesystem. So it would not necessary any-more to scan the partitions to mount a filesystem.

Re: [RFC][PATCH v2] mount.btrfs helper

2014-11-30 Thread Dimitri John Ledkov
Hello, On 30 November 2014 at 17:43, Goffredo Baroncelli kreij...@libero.it wrote: Hi all, this patch provides a mount.btrfs helper for the mount command. A btrfs filesystem could span several disks. This helper scans all the partitions to discover all the disks required to mount a

Re: [RFC][PATCH v2] mount.btrfs helper

2014-11-30 Thread cwillu
In ubuntu, the initfs runs a btrfs dev scan, which should catch anything that would be missed there. On Sun, Nov 30, 2014 at 4:11 PM, Dimitri John Ledkov x...@debian.org wrote: Hello, On 30 November 2014 at 17:43, Goffredo Baroncelli kreij...@libero.it wrote: Hi all, this patch provides a

Re: [RFC][PATCH v2] mount.btrfs helper

2014-11-30 Thread Dimitri John Ledkov
On 30 November 2014 at 22:31, cwillu cwi...@cwillu.com wrote: In ubuntu, the initfs runs a btrfs dev scan, which should catch anything that would be missed there. I'm sorry, udev rule(s) is not sufficient in the initramfs-less case, as outlined. In case of booting with initramfs, indeed,

Re: [RFC][PATCH v2] mount.btrfs helper

2014-11-30 Thread cwillu
Sorry, misread initrdless as initramfs. In #btrfs, I usually say something like do you gain enough by not using an initfs for this to be worth the hassle?, but of course, that's not an argument against making mount smarter. On Sun, Nov 30, 2014 at 4:57 PM, Dimitri John Ledkov x...@debian.org