Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified.

2013-02-20 Thread David Sterba
On Wed, Feb 06, 2013 at 05:41:42PM -0600, Mitch Harder wrote: On Wed, Feb 6, 2013 at 12:46 PM, Zach Brown z...@redhat.com wrote: + unsigned compressed_extent_size; It kind of jumps out that this mentions neither that it's the max nor that it's in KB. How about

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-20 Thread David Sterba
On Thu, Feb 07, 2013 at 03:38:34PM -0600, Mitch Harder wrote: --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -144,7 +144,7 @@ struct tree_block { unsigned int key_ready:1; }; -#define MAX_EXTENTS 128 +#define MAX_EXTENTS 512 I'm still not convinced this is needed and

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-20 Thread Liu Bo
On Thu, Feb 07, 2013 at 03:38:34PM -0600, Mitch Harder wrote: Provide for modification of the limit of compressed extent size utilizing mount-time configuration settings. The size of compressed extents was limited to 128K, which leads to fragmentation of the extents (although the extents

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-08 Thread David Sterba
On Thu, Feb 07, 2013 at 11:17:46PM -0600, Mitch Harder wrote: On Thu, Feb 7, 2013 at 6:28 PM, David Sterba d...@jikos.cz wrote: On Thu, Feb 07, 2013 at 03:38:34PM -0600, Mitch Harder wrote: --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -144,7 +144,7 @@ struct tree_block {

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-08 Thread Mitch Harder
On Fri, Feb 8, 2013 at 8:53 AM, David Sterba dste...@suse.cz wrote: On Thu, Feb 07, 2013 at 11:17:46PM -0600, Mitch Harder wrote: On Thu, Feb 7, 2013 at 6:28 PM, David Sterba d...@jikos.cz wrote: On Thu, Feb 07, 2013 at 03:38:34PM -0600, Mitch Harder wrote: --- a/fs/btrfs/relocation.c +++

[RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-07 Thread Mitch Harder
Provide for modification of the limit of compressed extent size utilizing mount-time configuration settings. The size of compressed extents was limited to 128K, which leads to fragmentation of the extents (although the extents themselves may still be located contiguously). This limit is put in

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-07 Thread Zach Brown
On Thu, Feb 07, 2013 at 03:38:34PM -0600, Mitch Harder wrote: Provide for modification of the limit of compressed extent size utilizing mount-time configuration settings. The size of compressed extents was limited to 128K, which leads to fragmentation of the extents (although the extents

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-07 Thread David Sterba
On Thu, Feb 07, 2013 at 03:38:34PM -0600, Mitch Harder wrote: --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -144,7 +144,7 @@ struct tree_block { unsigned int key_ready:1; }; -#define MAX_EXTENTS 128 +#define MAX_EXTENTS 512 Is this really related to compression? IIRC

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified v2

2013-02-07 Thread Mitch Harder
On Thu, Feb 7, 2013 at 6:28 PM, David Sterba d...@jikos.cz wrote: On Thu, Feb 07, 2013 at 03:38:34PM -0600, Mitch Harder wrote: --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -144,7 +144,7 @@ struct tree_block { unsigned int key_ready:1; }; -#define MAX_EXTENTS 128

[RFC] Btrfs: Allow the compressed extent size limit to be modified.

2013-02-06 Thread Mitch Harder
Provide for modification of the limit of compressed extent size utilizing mount-time configuration settings. The size of compressed extents was limited to 128K, which leads to fragmentation of the extents (although the extents themselves may still be located contiguously). This limit is put in

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified.

2013-02-06 Thread Zach Brown
+ unsigned compressed_extent_size; It kind of jumps out that this mentions neither that it's the max nor that it's in KB. How about max_compressed_extent_kb? + fs_info-compressed_extent_size = 128; I'd put a DEFAULT_MAX_EXTENTS up by the MAX_ definition instead of using a raw 128

Re: [RFC] Btrfs: Allow the compressed extent size limit to be modified.

2013-02-06 Thread Mitch Harder
On Wed, Feb 6, 2013 at 12:46 PM, Zach Brown z...@redhat.com wrote: + unsigned compressed_extent_size; It kind of jumps out that this mentions neither that it's the max nor that it's in KB. How about max_compressed_extent_kb? + fs_info-compressed_extent_size = 128; I'd put a