Re: [RFC] Converging userspace and kernel code

2017-01-11 Thread Anand Jain
Goldwyn, Could you add a list what functionality in btrfs-progs will be using the 'core'. ? There are too many to list. It would contain the algorithmic functions of btrfs which would be able to interact with both kernel and btrfs-progs. I am getting confused. How about a few from the

Re: [RFC] Converging userspace and kernel code

2017-01-10 Thread Goldwyn Rodrigues
On 01/10/2017 08:23 PM, Anand Jain wrote: > > > On 01/11/17 00:04, Goldwyn Rodrigues wrote: >> >> >> On 01/10/2017 09:20 AM, Anand Jain wrote: >>> >>> >>> On 01/10/17 20:14, Goldwyn Rodrigues wrote: On 01/09/2017 09:28 PM, Anand Jain wrote: > > Goldwyn, > > Could

Re: [RFC] Converging userspace and kernel code

2017-01-10 Thread Qu Wenruo
At 01/11/2017 10:23 AM, Anand Jain wrote: On 01/11/17 00:04, Goldwyn Rodrigues wrote: On 01/10/2017 09:20 AM, Anand Jain wrote: On 01/10/17 20:14, Goldwyn Rodrigues wrote: On 01/09/2017 09:28 PM, Anand Jain wrote: Goldwyn, Could you add a list what functionality in btrfs-progs wi

Re: [RFC] Converging userspace and kernel code

2017-01-10 Thread Anand Jain
On 01/11/17 00:04, Goldwyn Rodrigues wrote: On 01/10/2017 09:20 AM, Anand Jain wrote: On 01/10/17 20:14, Goldwyn Rodrigues wrote: On 01/09/2017 09:28 PM, Anand Jain wrote: Goldwyn, Could you add a list what functionality in btrfs-progs will be using the 'core'. ? There are too m

Re: [RFC] Converging userspace and kernel code

2017-01-10 Thread Goldwyn Rodrigues
On 01/10/2017 09:20 AM, Anand Jain wrote: > > > On 01/10/17 20:14, Goldwyn Rodrigues wrote: >> >> >> On 01/09/2017 09:28 PM, Anand Jain wrote: >>> >>> Goldwyn, >>> >>> Could you add a list what functionality in btrfs-progs will >>> be using the 'core'. ? >> >> >> There are too many to list. I

Re: [RFC] Converging userspace and kernel code

2017-01-10 Thread Anand Jain
On 01/10/17 20:14, Goldwyn Rodrigues wrote: On 01/09/2017 09:28 PM, Anand Jain wrote: Goldwyn, Could you add a list what functionality in btrfs-progs will be using the 'core'. ? There are too many to list. It would contain the algorithmic functions of btrfs which would be able to inte

Re: [RFC] Converging userspace and kernel code

2017-01-10 Thread Goldwyn Rodrigues
On 01/09/2017 09:28 PM, Anand Jain wrote: > > Goldwyn, > > Could you add a list what functionality in btrfs-progs will > be using the 'core'. ? There are too many to list. It would contain the algorithmic functions of btrfs which would be able to interact with both kernel and btrfs-progs.

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Anand Jain
Goldwyn, Could you add a list what functionality in btrfs-progs will be using the 'core'. ? Thanks, Anand On 01/08/17 21:16, Goldwyn Rodrigues wrote: 1. Motivation While fixing user space tools for btrfs-progs, I found a couple of bugs which are already solved in kernel space but were not

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Qu Wenruo
At 01/10/2017 09:46 AM, Darrick J. Wong wrote: On Mon, Jan 09, 2017 at 04:38:22PM -0500, Jeff Mahoney wrote: On 1/9/17 4:34 PM, Omar Sandoval wrote: On Mon, Jan 09, 2017 at 09:31:39AM -0600, Eric Sandeen wrote: On 1/8/17 8:11 PM, Qu Wenruo wrote: At 01/08/2017 09:16 PM, Goldwyn Rodrigues

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Darrick J. Wong
On Mon, Jan 09, 2017 at 04:38:22PM -0500, Jeff Mahoney wrote: > On 1/9/17 4:34 PM, Omar Sandoval wrote: > > On Mon, Jan 09, 2017 at 09:31:39AM -0600, Eric Sandeen wrote: > >> On 1/8/17 8:11 PM, Qu Wenruo wrote: > >>> > >>> > >>> At 01/08/2017 09:16 PM, Goldwyn Rodrigues wrote: > > 1. Moti

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Omar Sandoval
On Tue, Jan 10, 2017 at 08:35:26AM +0800, Qu Wenruo wrote: > That depends on how independent the "core" btrfs part is. > > If completely independent,(Don't ever has any page/VFS/race code) I'm > completely fine with that. > > But the problem is, at least from current code base, even btrfs_path >

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Qu Wenruo
At 01/09/2017 08:06 PM, Goldwyn Rodrigues wrote: On 01/08/2017 08:11 PM, Qu Wenruo wrote: At 01/08/2017 09:16 PM, Goldwyn Rodrigues wrote: 1. Motivation While fixing user space tools for btrfs-progs, I found a couple of bugs which are already solved in kernel space but were not ported to

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Jeff Mahoney
On 1/9/17 4:34 PM, Omar Sandoval wrote: > On Mon, Jan 09, 2017 at 09:31:39AM -0600, Eric Sandeen wrote: >> On 1/8/17 8:11 PM, Qu Wenruo wrote: >>> >>> >>> At 01/08/2017 09:16 PM, Goldwyn Rodrigues wrote: 1. Motivation While fixing user space tools for btrfs-progs, I found a couple of

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Omar Sandoval
On Mon, Jan 09, 2017 at 09:31:39AM -0600, Eric Sandeen wrote: > On 1/8/17 8:11 PM, Qu Wenruo wrote: > > > > > > At 01/08/2017 09:16 PM, Goldwyn Rodrigues wrote: > >> > >> 1. Motivation > >> While fixing user space tools for btrfs-progs, I found a couple of bugs > >> which are already solved in ke

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Eric Sandeen
On 1/8/17 8:11 PM, Qu Wenruo wrote: > > > At 01/08/2017 09:16 PM, Goldwyn Rodrigues wrote: >> >> 1. Motivation >> While fixing user space tools for btrfs-progs, I found a couple of bugs >> which are already solved in kernel space but were not ported to user >> space. User space is a little ignore

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Goldwyn Rodrigues
On 01/08/2017 08:11 PM, Qu Wenruo wrote: > > > At 01/08/2017 09:16 PM, Goldwyn Rodrigues wrote: >> >> 1. Motivation >> While fixing user space tools for btrfs-progs, I found a couple of bugs >> which are already solved in kernel space but were not ported to user >> space. User space is a little

Re: [RFC] Converging userspace and kernel code

2017-01-09 Thread Christoph Hellwig
On Mon, Jan 09, 2017 at 10:11:29AM +0800, Qu Wenruo wrote: > (I'm already trying to re-implement btrfs_map_block() in btrfs-progs with a > better interface in out-of-tree offline scrub patchset) How about doing the right thing in the kernel as well? While looking at the btrfs abuse of the block R

Re: [RFC] Converging userspace and kernel code

2017-01-08 Thread Qu Wenruo
At 01/08/2017 09:16 PM, Goldwyn Rodrigues wrote: 1. Motivation While fixing user space tools for btrfs-progs, I found a couple of bugs which are already solved in kernel space but were not ported to user space. User space is a little ignored when it comes to fixing bugs in the core functionali

[RFC] Converging userspace and kernel code

2017-01-08 Thread Goldwyn Rodrigues
1. Motivation While fixing user space tools for btrfs-progs, I found a couple of bugs which are already solved in kernel space but were not ported to user space. User space is a little ignored when it comes to fixing bugs in the core functionality. XFS developers have already performed this and th