Re: [RFC] Move all btrfs command to only one command

2010-08-26 Thread James Smith
diff --git a/btrfs_cmds.c b/btrfs_cmds.c index e112902..271ca89 100644 --- a/btrfs_cmds.c +++ b/btrfs_cmds.c @@ -497,7 +497,7 @@ static void print_one_uuid(struct btrfs_fs_devices *fs_devices) devs_found++; } if (devs_found < total) { - printf("\t*** So

Re: [RFC] Move all btrfs command to only one command

2010-08-21 Thread Goffredo Baroncelli
On Saturday, 21 August, 2010, James Smith wrote: [...] > I'll look at a error.txt file (after finding convention) and also > update the man. In regards to shortening of dev/device -- is this > really neccessary? And what harm does this cause in the first place? > In device add-delete functionality.

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread James Smith
Truthfully, this is probably this first I've actually done in C++; I used to do PHP and a small amount of Javascript. I like that the tool has seen some work and decided to at least attempt a bit more work towards a decent tool. Re: ERR codes. I don't know if a uniform approach is what's needed fo

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Josh Berry
On Fri, Aug 20, 2010 at 12:00, Andreas Philipp wrote: >  On 20.08.2010 20:49, Josh Berry wrote: >> >> On Fri, Aug 20, 2010 at 11:34, Andreas Philipp >>  wrote: >>> >>>  On 20.08.2010 20:27, Josh Berry wrote: On Fri, Aug 20, 2010 at 05:03, Goffredo Baroncelli  wrote: > > On

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Goffredo Baroncelli
On Friday, 20 August, 2010, Josh Berry wrote: > On Fri, Aug 20, 2010 at 11:34, Andreas Philipp > wrote: > > On 20.08.2010 20:27, Josh Berry wrote: > >> > >> On Fri, Aug 20, 2010 at 05:03, Goffredo Baroncelli > >> wrote: > >>> > >>> On Thursday, 19 August, 2010, James Smith wrote: > > T

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Andreas Philipp
On 20.08.2010 20:49, Josh Berry wrote: On Fri, Aug 20, 2010 at 11:34, Andreas Philipp wrote: On 20.08.2010 20:27, Josh Berry wrote: On Fri, Aug 20, 2010 at 05:03, Goffredo Baroncelli wrote: On Thursday, 19 August, 2010, James Smith wrote: This patch randomizes the error codes and also

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Goffredo Baroncelli
On Friday, 20 August, 2010, Benjamin Griese wrote: > Hello guys, > > I would also prefer doing it in an all-in-one tool with various parameters. > I like the concept how the Solaris-Devs did it by consolidating every > special configuration tool to an "xyzadm"-binary (idea: btrfsadm? i.e. > simila

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Josh Berry
On Fri, Aug 20, 2010 at 11:34, Andreas Philipp wrote: >  On 20.08.2010 20:27, Josh Berry wrote: >> >> On Fri, Aug 20, 2010 at 05:03, Goffredo Baroncelli >>  wrote: >>> >>> On Thursday, 19 August, 2010, James Smith wrote: This patch randomizes the error codes and also fixes up some typos

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Andreas Philipp
On 20.08.2010 20:27, Josh Berry wrote: On Fri, Aug 20, 2010 at 05:03, Goffredo Baroncelli wrote: On Thursday, 19 August, 2010, James Smith wrote: This patch randomizes the error codes and also fixes up some typos including capitalization in the output. It would almost be nice to see a tran

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Josh Berry
On Fri, Aug 20, 2010 at 05:03, Goffredo Baroncelli wrote: > On Thursday, 19 August, 2010, James Smith wrote: >> This patch randomizes the error codes and also fixes up some typos > including >> capitalization in the output. >> >> It would almost be nice to see a translation effort for the tool as

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Benjamin Griese
Hello guys, I would also prefer doing it in an all-in-one tool with various parameters. I like the concept how the Solaris-Devs did it by consolidating every special configuration tool to an "xyzadm"-binary (idea: btrfsadm? i.e. similar to mdadm?). For me as an admin it is easier to remember only

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Jon Nelson
On Fri, Aug 20, 2010 at 7:03 AM, Goffredo Baroncelli wrote: > > > +                       fprintf(stderr, "ERR-A.11: in command '"); > > I am not against this kind of error codes, but I prefer > > +                       fprintf(stderr, "Error 'ERR-A.11' in command '"); > > And a file.txt which de

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Goffredo Baroncelli
On Friday, 20 August, 2010, Goffredo Baroncelli wrote: > On Thursday, 19 August, 2010, James Smith wrote: > > This patch randomizes the error codes and also fixes up some typos > including > > capitalization in the output. I think that you should also update the btrfs man page in order to reflect

Re: [RFC] Move all btrfs command to only one command

2010-08-20 Thread Goffredo Baroncelli
On Thursday, 19 August, 2010, James Smith wrote: > This patch randomizes the error codes and also fixes up some typos including > capitalization in the output. > > It would almost be nice to see a translation effort for the tool as well. > Hi James, I don't comment the changing the capitalizat

Re: [RFC] Move all btrfs command to only one command

2010-08-19 Thread James Smith
This patch randomizes the error codes and also fixes up some typos including capitalization in the output. It would almost be nice to see a translation effort for the tool as well. diff --git a/btrfs.c b/btrfs.c index 4d263c4..3418837 100644 --- a/btrfs.c +++ b/btrfs.c @@ -44,52 +44,52 @@ static s

Re: [RFC] Move all btrfs command to only one command: btrfs.c

2010-02-11 Thread Goffredo Baroncelli
On Thursday 11 February 2010, rk wrote: > . it would be good to have some "mechanism" that will "prevent" people > mixing -d with -D btrfs checks that the path passed to -D command is referred to a subvolume. If there is an agreement I am open to change the switch (-d) of the defrag command. BR

Re: [RFC] Move all btrfs command to only one command: btrfs.c

2010-02-11 Thread rk
.. it would be good to have some "mechanism" that will "prevent" people mixing -d with -D Chris Mason wrote: > On Sun, Jan 24, 2010 at 06:35:33PM +0100, Goffredo Baroncelli wrote: > >> Hi all, >> >> this is a follow-up of the previous email. I rewrite the btrfs command in C. >> Now the followi

Re: [RFC] Move all btrfs command to only one command: btrfs.c

2010-02-11 Thread Goffredo Baroncelli
On Thursday 11 February 2010, Chris Mason wrote: > On Sun, Jan 24, 2010 at 06:35:33PM +0100, Goffredo Baroncelli wrote: > > Hi all, > > > > this is a follow-up of the previous email. I rewrite the btrfs command in C. > > Now the following actions are implemented: > > > > snapshot (-s) -> create

Re: [RFC] Move all btrfs command to only one command: btrfs.c

2010-02-11 Thread Chris Mason
On Sun, Jan 24, 2010 at 06:35:33PM +0100, Goffredo Baroncelli wrote: > Hi all, > > this is a follow-up of the previous email. I rewrite the btrfs command in C. > Now the following actions are implemented: > > snapshot (-s) -> create a snapshot > delete (-D) -> delete a subvolume or a snapshot

Re: [RFC] Move all btrfs command to only one command: btrfs.c

2010-01-24 Thread Piavlo
Goffredo Baroncelli wrote: > Hi all, > > this is a follow-up of the previous email. I rewrite the btrfs command in C. > Now the following actions are implemented: > > snapshot (-s) -> create a snapshot > delete (-D) -> delete a subvolume or a snapshot > create (-S) -> create a subvolume > defr

[RFC] Move all btrfs command to only one command: btrfs.c

2010-01-24 Thread Goffredo Baroncelli
Hi all, this is a follow-up of the previous email. I rewrite the btrfs command in C. Now the following actions are implemented: snapshot (-s) -> create a snapshot delete (-D) -> delete a subvolume or a snapshot create (-S) -> create a subvolume defrag (-d) -> defrag a tree or a file fssync

R: Re: [RFC] Move all btrfs command to only one command

2010-01-22 Thread kreij...@libero.it
>Messaggio originale >Da: avbid...@fortytwo.ch >Data: 22/01/2010 9.23 >A: >Cc: "Goffredo Baroncelli" >Ogg: Re: [RFC] Move all btrfs command to only one command > >Hi, > >I like this very much, I found myself wondering which program did what again

Re: [RFC] Move all btrfs command to only one command

2010-01-22 Thread Adrian von Bidder
Hi, I like this very much, I found myself wondering which program did what again and again when I started to use btrfs, too. On Thursday 21 January 2010 20.29:26 Goffredo Baroncelli wrote: >btrfs resize|-r [+/-][gkm]|max >Resize the file system. If 'max' is passed, the f

Re: [RFC] Move all btrfs command to only one command

2010-01-22 Thread Xavier Nicollet
Le 22 janvier 2010 à 01:11, Michael Niederle a écrit: > > btrfs clone|-c [/] > > Clone the subvolume with the name in the > > > > directory. > > Maybe you should add the "writable snapshot" in t

Re: [RFC] Move all btrfs command to only one command

2010-01-21 Thread Michael Niederle
> $ btrfs > Usage: > btrfs clone|-c [/] > Clone the subvolume with the name in the > > directory. > > btrfs delete|-

Re: [RFC] Move all btrfs command to only one command

2010-01-21 Thread TARUISI Hiroaki
Hi Goffredo, It sounds good for me though detailed points need more discussion. btrfs-progs seems unkind for operator as you mentioned, and many features will be implemented to btrfsctl from now, it's good that we arrange and unify btrfs-progs now. As for me, plain keywords(delete,defrag...) as c

[RFC] Move all btrfs command to only one command

2010-01-21 Thread Goffredo Baroncelli
Hi all this RFC is about unify all btrfs command (btrfsctl, btrfs-show, btrfs-tune.. ) in only one called "btrfs" (or whatever we want). Today "btrfsctl" needs a "bit" of care because * the help is basically wrong [1] * the return codes are incoherent [2] * the syntax of the command are ve