Re: [RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-26 Thread Anand Jain
Thanks Jeff for the comments. On 10/23/2015 11:24 PM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/15 4:45 AM, Anand Jain wrote: mkfs from latest btrfs-progs will enable latest default features, and if the kernel is down-rev and does not support a latest default

Re: [RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-23 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/15 4:45 AM, Anand Jain wrote: > mkfs from latest btrfs-progs will enable latest default features, > and if the kernel is down-rev and does not support a latest > default feature then mount fails, as expected. > > This patch disables default

Re: [RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-21 Thread Qu Wenruo
Anand Jain wrote on 2015/10/22 11:09 +0800: Hi, more details about this RFC as below.. So a user with old kernel won't be able to create a filesystem with newer feature forever. Thats not true. Here below is an example of the problem and fix in action. Maybe the user are just mak

Re: [RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-21 Thread Anand Jain
Hi, more details about this RFC as below.. So a user with old kernel won't be able to create a filesystem with newer feature forever. Thats not true. Here below is an example of the problem and fix in action. Maybe the user are just making btrfs for his or her newer kernel? Yes. Tha

Re: [RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-21 Thread Qu Wenruo
在 2015年10月21日 22:15, Anand Jain 写道: Thanks for the comments.. more below. On 10/21/2015 05:12 PM, Qu Wenruo wrote: Anand Jain wrote on 2015/10/21 16:45 +0800: mkfs from latest btrfs-progs will enable latest default features, and if the kernel is down-rev and does not support a latest defa

Re: [RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-21 Thread Anand Jain
Thanks for the comments.. more below. On 10/21/2015 05:12 PM, Qu Wenruo wrote: Anand Jain wrote on 2015/10/21 16:45 +0800: mkfs from latest btrfs-progs will enable latest default features, and if the kernel is down-rev and does not support a latest default feature then mount fails, as expect

Re: [RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-21 Thread Qu Wenruo
Anand Jain wrote on 2015/10/21 16:45 +0800: mkfs from latest btrfs-progs will enable latest default features, and if the kernel is down-rev and does not support a latest default feature then mount fails, as expected. This patch disables default features based on the running kernel. Signed-off

[RFC PATCH 2/3] btrfs-progs: kernel based default features for mkfs

2015-10-21 Thread Anand Jain
mkfs from latest btrfs-progs will enable latest default features, and if the kernel is down-rev and does not support a latest default feature then mount fails, as expected. This patch disables default features based on the running kernel. Signed-off-by: Anand Jain --- mkfs.c | 5 - 1 file c