Re: [RFC PATCH v2 3/5] btrfs: generalize btrfs_lookup_bio_sums_dio()

2019-10-18 Thread Omar Sandoval
On Wed, Oct 16, 2019 at 12:22:33PM +0300, Nikolay Borisov wrote: > > > On 15.10.19 г. 21:42 ч., Omar Sandoval wrote: > > From: Omar Sandoval > > > > This isn't actually dio-specific; it just looks up the csums starting at > > the given offset instead of using the page index. Rename it to > > bt

Re: [RFC PATCH v2 3/5] btrfs: generalize btrfs_lookup_bio_sums_dio()

2019-10-16 Thread Nikolay Borisov
On 15.10.19 г. 21:42 ч., Omar Sandoval wrote: > From: Omar Sandoval > > This isn't actually dio-specific; it just looks up the csums starting at > the given offset instead of using the page index. Rename it to > btrfs_lookup_bio_sums_at_offset() and add the dst parameter. We might > even want

[RFC PATCH v2 3/5] btrfs: generalize btrfs_lookup_bio_sums_dio()

2019-10-15 Thread Omar Sandoval
From: Omar Sandoval This isn't actually dio-specific; it just looks up the csums starting at the given offset instead of using the page index. Rename it to btrfs_lookup_bio_sums_at_offset() and add the dst parameter. We might even want to expose __btrfs_lookup_bio_sums() as the public API instead