Re: [RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode

2016-05-23 Thread Qu Wenruo
David Sterba wrote on 2016/05/23 13:08 +0200: On Fri, May 20, 2016 at 10:33:55AM +0800, Qu Wenruo wrote: We'll enrich the test cases for current low memory mode. I started something to add optional default options for a few basic commands (mkfs, fsck, convert) to extend the coverage. I'm not

Re: [RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode

2016-05-23 Thread David Sterba
On Fri, May 20, 2016 at 10:33:55AM +0800, Qu Wenruo wrote: > We'll enrich the test cases for current low memory mode. I started something to add optional default options for a few basic commands (mkfs, fsck, convert) to extend the coverage. I'm not finished, the idea is to call the commands via so

Re: [RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode

2016-05-19 Thread Qu Wenruo
David Sterba wrote on 2016/05/19 16:51 +0200: On Wed, May 18, 2016 at 08:58:57AM +0800, Qu Wenruo wrote: Josef Bacik wrote on 2016/05/17 11:29 -0400: On 05/17/2016 05:38 AM, Qu Wenruo wrote: Thanks for the review. I'll add it to github branch to avoid unneeded mail bombing. Thanks. I di

Re: [RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode

2016-05-19 Thread David Sterba
On Wed, May 18, 2016 at 08:58:57AM +0800, Qu Wenruo wrote: > Josef Bacik wrote on 2016/05/17 11:29 -0400: > > On 05/17/2016 05:38 AM, Qu Wenruo wrote: > > > Thanks for the review. > > I'll add it to github branch to avoid unneeded mail bombing. Thanks. I did one more pass and fixed the error mes

Re: [RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode

2016-05-17 Thread Qu Wenruo
Josef Bacik wrote on 2016/05/17 11:29 -0400: On 05/17/2016 05:38 AM, Qu Wenruo wrote: From: Lu Fengqi You can add Reviewed-by: Josef Bacik To the whole series. Thanks, Josef Thanks for the review. I'll add it to github branch to avoid unneeded mail bombing. Thanks Qu -- To unsu

Re: [RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode

2016-05-17 Thread Josef Bacik
On 05/17/2016 05:38 AM, Qu Wenruo wrote: From: Lu Fengqi You can add Reviewed-by: Josef Bacik To the whole series. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

[RFC PATCH v2.1 16/16] btrfs-progs: fsck: Introduce low memory mode

2016-05-17 Thread Qu Wenruo
From: Lu Fengqi Introduce a new fsck mode: low memory mode. Old btrfsck is doing a quite efficient but uses some memory for each extent item. Old method will ensure extents are only iterated once at extent/chunk tree check process. But since it uses a little memory for each extent item, for lar