Re: [btrfs-progs] [bug][patch] Leaking file handle in scrub_fs_info()

2012-06-05 Thread Hugo Mills
Hi, Goffredo, I'm trying to do a new integration branch, and the patch inline in the text is corrupt (plus it has a massively verbose commit message): Applying: Leaking file handle in scrub_fs_info() fatal: corrupt patch at line 74 Patch failed at 0001 Leaking file handle in

Re: [btrfs-progs] [bug][patch] Leaking file handle in scrub_fs_info()

2012-04-25 Thread Jan Schmidt
Hi Goffredo, On 24.04.2012 20:43, Goffredo Baroncelli wrote: I was giving a look to the function scrub_fs_info( ), and to me it seems that could be a potential file handle leaking problem. It's only a single fd that's closed upon exit, but anyway... In fact: static int scrub_fs_info(int

Re: [btrfs-progs] [bug][patch] Leaking file handle in scrub_fs_info()

2012-04-25 Thread Goffredo Baroncelli
On 04/25/2012 11:39 AM, Jan Schmidt wrote: Hi Goffredo, On 24.04.2012 20:43, Goffredo Baroncelli wrote: I was giving a look to the function scrub_fs_info( ), and to me it seems that could be a potential file handle leaking problem. It's only a single fd that's closed upon exit, but

[btrfs-progs] [bug][patch] Leaking file handle in scrub_fs_info()

2012-04-24 Thread Goffredo Baroncelli
Hi Jan, I was giving a look to the function scrub_fs_info( ), and to me it seems that could be a potential file handle leaking problem. In fact: static int scrub_fs_info(int fd, char *path, struct btrfs_ioctl_fs_info_args *fi_args, struct