Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Theodore Ts'o
On Wed, Oct 03, 2012 at 11:29:58AM -0700, Wade Cline wrote: > In this case, dir_iterate_proc() is being passed into > ext2_dir_iterate2() and is called from ext2fs_process_dir_block(), > not readdir(2). It looks like the main issue would be detecting if the > EXT2_FEATURE_INCOMPAT_FILETYPE flag is

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Wade Cline
On 10/03/2012 10:58 AM, Theodore Ts'o wrote: To clarify, the EXT2_FEATURE_INCOMPAT_FILETYPE flag indicates that there _may_ be file type information in the directory entry (and so only the low 8 bits of name_len should be considered part of the name length), but it does not guarantee that it wil

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Theodore Ts'o
On Wed, Oct 03, 2012 at 10:39:55AM -0700, Wade Cline wrote: > >I would think that using (name_len& 0xFF) is a much simpler solution, > >and my suggestion is to not depend on the file type in the directory > >entry (since there might be some very old ext2 file systems that don't > >set the file typ

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-03 Thread Wade Cline
On 10/02/2012 02:08 PM, Theodore Ts'o wrote: On Tue, Oct 02, 2012 at 12:02:22PM -0700, Wade Cline wrote: Hello Theodore Ts'o, Is there a function similar to ext2fs_dir_iterate2() that will call a hook function on an ext2_dir_entry_2 structure and not an ext2_dir_entry structure? The reason I

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-02 Thread Theodore Ts'o
On Tue, Oct 02, 2012 at 12:02:22PM -0700, Wade Cline wrote: > Hello Theodore Ts'o, > > Is there a function similar to ext2fs_dir_iterate2() that will call a hook > function on an ext2_dir_entry_2 structure and not an ext2_dir_entry > structure? > > The reason I ask is because btrfs-convert curren

[e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-02 Thread Wade Cline
Hello Theodore Ts'o, Is there a function similar to ext2fs_dir_iterate2() that will call a hook function on an ext2_dir_entry_2 structure and not an ext2_dir_entry structure? The reason I ask is because btrfs-convert currently tries to do a cast between the two structures as such: stati