Re: [patch] Move nodesize/leafsize/sectorsize to fs_info

2011-10-31 Thread David Sterba
Hi Simon, On Sun, Aug 07, 2011 at 11:54:31PM +0200, Peeters Simon wrote: > moved nodesize, leafsize and sectorsize from btrfs_root to > btrfs_fs_info as mentioned in [1] and updated everything accordingly. > patch against the "for-linus" tree > builds and loads, no further testing done. Please ad

Re: [patch] Move nodesize/leafsize/sectorsize to fs_info

2011-10-26 Thread Arne Jansen
On 10/26/2011 06:27 PM, Chris Mason wrote: On Wed, Oct 26, 2011 at 06:23:38PM +0200, David Sterba wrote: On Wed, Oct 26, 2011 at 04:47:15PM +0200, Arne Jansen wrote: The sizes get initialized to 4096, but after the super block is read, these are replaced by those from the SB. [reads sources a

Re: [patch] Move nodesize/leafsize/sectorsize to fs_info

2011-10-26 Thread Chris Mason
On Wed, Oct 26, 2011 at 06:23:38PM +0200, David Sterba wrote: > On Wed, Oct 26, 2011 at 04:47:15PM +0200, Arne Jansen wrote: > > The sizes get initialized to 4096, but after the super block is read, > > these are replaced by those from the SB. > > [reads sources again] right, and the initial value

Re: [patch] Move nodesize/leafsize/sectorsize to fs_info

2011-10-26 Thread David Sterba
On Wed, Oct 26, 2011 at 04:47:15PM +0200, Arne Jansen wrote: > The sizes get initialized to 4096, but after the super block is read, > these are replaced by those from the SB. [reads sources again] right, and the initial values are not used up to that point, so 4096 could be any number. > It was

Re: [patch] Move nodesize/leafsize/sectorsize to fs_info

2011-10-26 Thread Arne Jansen
On 10/26/2011 03:34 PM, David Sterba wrote: Hi, sorry for late reply. This patch tries to unify node-/leaf-/... sizes nad put it just into fs_info, but this assumes all trees share the same sizes. Unfortunatelly this is not true (once we allow big blocks; soon?). The root tree has a hardcoded s

Re: [patch] Move nodesize/leafsize/sectorsize to fs_info

2011-10-26 Thread David Sterba
Hi, sorry for late reply. This patch tries to unify node-/leaf-/... sizes nad put it just into fs_info, but this assumes all trees share the same sizes. Unfortunatelly this is not true (once we allow big blocks; soon?). The root tree has a hardcoded size of 4k, see the __setup_root called with 4k

[patch] Move nodesize/leafsize/sectorsize to fs_info

2011-08-07 Thread Peeters Simon
moved nodesize, leafsize and sectorsize from btrfs_root to btrfs_fs_info as mentioned in [1] and updated everything accordingly. patch against the "for-linus" tree builds and loads, no further testing done. [1] https://btrfs.wiki.kernel.org/index.php/Cleanup_ideas ps: "Pass fs_info instead of ro