Re: [patch] error handling of ERR_PTR() returns

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrey Kuzmin wrote: > Since both NULL ptr and IS_ERR(ptr) are treated as error, why not > redefine IS_ERR to handle both, simplifying caller's life? IS_ERR is a global kernel function, and NULL isn't always an error. - -Jeff > On Tue, Apr 7, 2009 a

Re: [patch] error handling of ERR_PTR() returns

Since both NULL ptr and IS_ERR(ptr) are treated as error, why not redefine IS_ERR to handle both, simplifying caller's life? Regards, Andrey On Tue, Apr 7, 2009 at 5:38 PM, Dan Carpenter wrote: > There are a couple functions which return ERR_PTR as well as NULL.  The > caller needs to handle b

[patch] error handling of ERR_PTR() returns

There are a couple functions which return ERR_PTR as well as NULL. The caller needs to handle both. Smatch also complains about the handling of alloc_extent_map() but as far as I can see that doesn't actually return an ERR_PTR. Compile tested on 2.6.29. regards, dan carpenter --- orig/fs/btr