Re: [patch v2] Btrfs: fix error handling in __add_reloc_root()

2012-06-26 Thread Dan Carpenter
...@oracle.com Subject: [patch v2] Btrfs: fix error handling in __add_reloc_root() 3) $ git am /home/dcarpenter/tmp/html2/btrfs_raw.txt Applying: Btrfs: fix error handling in __add_reloc_root() regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-btrfs

[patch v2] Btrfs: fix error handling in __add_reloc_root()

2012-06-25 Thread Dan Carpenter
We dereferenced node in the error message after freeing it. Also btrfs_panic() can return so we should return an error code instead of continuing. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: in the first version I just deleted the kfree(). diff --git a/fs/btrfs/relocation.c

Re: [patch v2] Btrfs: fix error handling in __add_reloc_root()

2012-06-25 Thread Josef Bacik
On Mon, Jun 25, 2012 at 05:15:23AM -0600, Dan Carpenter wrote: We dereferenced node in the error message after freeing it. Also btrfs_panic() can return so we should return an error code instead of continuing. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: in the first

Re: [patch v2] Btrfs: fix error handling in __add_reloc_root()

2012-06-25 Thread Dan Carpenter
On Mon, Jun 25, 2012 at 09:41:12AM -0400, Josef Bacik wrote: On Mon, Jun 25, 2012 at 05:15:23AM -0600, Dan Carpenter wrote: We dereferenced node in the error message after freeing it. Also btrfs_panic() can return so we should return an error code instead of continuing. Signed-off-by:

Re: [patch v2] Btrfs: fix error handling in __add_reloc_root()

2012-06-25 Thread santosh prasad nayak
I am also facing similar issue while applying this patch. [santosh@localhost linux-next]$ sudo git am mail_Dan.txt Patch format detection failed. [santosh@localhost linux-next]$ regards santosh On Mon, Jun 25, 2012 at 7:23 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Mon, Jun 25,