Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-12-04 Thread David Sterba
On Fri, Dec 04, 2015 at 09:21:59AM +0800, Qu Wenruo wrote: > > We do have the alignment check in kernel, but it's in the early phase > > where we don't know if nodesize is reliable and print only a warning. > > > This can be enhanced by the following method: At minimum, we can promote the 4k

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-12-04 Thread Qu Wenruo
On 12/04/2015 09:12 PM, David Sterba wrote: On Fri, Dec 04, 2015 at 09:21:59AM +0800, Qu Wenruo wrote: We do have the alignment check in kernel, but it's in the early phase where we don't know if nodesize is reliable and print only a warning. This can be enhanced by the following method:

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-12-03 Thread David Sterba
On Mon, Nov 30, 2015 at 11:05:20PM +0100, Vegard Nossum wrote: > With your patch and a new image, I run into a second issue (which is > probably unrelated): Yes, it's unrelated. As pointed out by Qu, the alignment is wrong and more strict checks should catch it. > Should I start a new thread?

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-12-03 Thread David Sterba
On Tue, Dec 01, 2015 at 08:50:57AM +0800, Qu Wenruo wrote: > Btrfsck already gives quite good clue on the problem: > > ERROR: chunk_root block unaligned: 4294967168 > ERROR: chunk_root block unaligned: 4294967168 > > Chunk root in superblock is not aligned, and the superblock is not valid. > >

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-12-03 Thread Qu Wenruo
David Sterba wrote on 2015/12/03 18:47 +0100: On Tue, Dec 01, 2015 at 08:50:57AM +0800, Qu Wenruo wrote: Btrfsck already gives quite good clue on the problem: ERROR: chunk_root block unaligned: 4294967168 ERROR: chunk_root block unaligned: 4294967168 Chunk root in superblock is not aligned,

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-11-30 Thread Vegard Nossum
0 /mnt/0/ BTRFS: device fsid 9006933e-2a9a-44f0-917f-514252aeec2c devid 1 transid 7 /dev/loop0 BTRFS info (device loop0): disk space caching is enabled BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()! The fix, worked for me on the provided image: https://patchwork.kernel.org/patch/772

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-11-30 Thread David Sterba
.0 /mnt/0/ > > BTRFS: device fsid 9006933e-2a9a-44f0-917f-514252aeec2c devid 1 transid > > 7 /dev/loop0 > > BTRFS info (device loop0): disk space caching is enabled > > BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()! The fix, worked for me on the provided image:

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-11-30 Thread Qu Wenruo
: """ # mount -o loop -t btrfs ./btrfs.0 /mnt/0/ BTRFS: device fsid 9006933e-2a9a-44f0-917f-514252aeec2c devid 1 transid 7 /dev/loop0 BTRFS info (device loop0): disk space caching is enabled BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()! The fix, worked for me on the

Re: BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-11-30 Thread David Sterba
d > 7 /dev/loop0 > BTRFS info (device loop0): disk space caching is enabled > BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()! Looks like a fuzzed image, it blows when num_stripes is 0 335 static inline unsigned long btrfs_chunk_item_size(int num_stripes) 336 { 337

BUG: failure at fs/btrfs/ctree.h:337/btrfs_chunk_item_size()!

2015-11-15 Thread Vegard Nossum
Hi, With the attached btrfs image, I get the following splat when mounting: """ # mount -o loop -t btrfs ./btrfs.0 /mnt/0/ BTRFS: device fsid 9006933e-2a9a-44f0-917f-514252aeec2c devid 1 transid 7 /dev/loop0 BTRFS info (device loop0): disk space caching is enabled BUG: fail