Re: Btrfs and data nocow per inode basis

2012-06-13 Thread Liu Bo
On 06/13/2012 05:10 AM, Ted Ts'o wrote: > On Tue, Jun 12, 2012 at 04:44:23PM -0400, Chris Mason wrote: >> On Tue, Jun 12, 2012 at 01:15:27PM -0600, Ted Ts'o wrote: >>> It appears the NOCOW_FL flag is currently a no-op in the 3.2 kernel? >> It's not a noop, but it is only setting the NODATACOW flag

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Ted Ts'o
... and e2fsprogs 1.42.4 has been released, with the No_COW lsattr and chattr support. It's in all of the usual places: ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/e2fsprogs/v1.42.4 and http://prdownloads.sourceforge.net/e2fsprogs/e2fsprogs-1.42.4.tar.gz ... and I've uploaded a release

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread David Sterba
On Tue, Jun 12, 2012 at 04:44:23PM -0400, Chris Mason wrote: > On Tue, Jun 12, 2012 at 01:15:27PM -0600, Ted Ts'o wrote: > > It appears the NOCOW_FL flag is currently a no-op in the 3.2 kernel? > > It's not a noop, but it is only setting the NODATACOW flag. It needs to > set the nodatasum flag as

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Ted Ts'o
On Tue, Jun 12, 2012 at 04:44:23PM -0400, Chris Mason wrote: > On Tue, Jun 12, 2012 at 01:15:27PM -0600, Ted Ts'o wrote: > > It appears the NOCOW_FL flag is currently a no-op in the 3.2 kernel? > > It's not a noop, but it is only setting the NODATACOW flag. It needs to > set the nodatasum flag as

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Goffredo Baroncelli
On 06/12/2012 10:44 PM, Chris Mason wrote: > On Tue, Jun 12, 2012 at 01:15:27PM -0600, Ted Ts'o wrote: >> It appears the NOCOW_FL flag is currently a no-op in the 3.2 kernel? > > It's not a noop, but it is only setting the NODATACOW flag. It needs to > set the nodatasum flag as well, just like th

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Chris Mason
On Tue, Jun 12, 2012 at 01:15:27PM -0600, Ted Ts'o wrote: > It appears the NOCOW_FL flag is currently a no-op in the 3.2 kernel? It's not a noop, but it is only setting the NODATACOW flag. It needs to set the nodatasum flag as well, just like the mount -o nodatacow mount option does. I'll fix th

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Ted Ts'o
It appears the NOCOW_FL flag is currently a no-op in the 3.2 kernel? {/mnt} 2062# grep /mnt /proc/mounts /dev/mapper/funarg-btrfs /mnt btrfs rw,relatime,space_cache 0 0 {/mnt} 2063# sync ; filefrag -v a Filesystem type is: 9123683e File size of a is 32768 (8 blocks, blocksize 4096) ext log

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Ted Ts'o
On Tue, Jun 12, 2012 at 07:41:25PM +0200, Goffredo Baroncelli wrote: > > After a bit of googling I found a Liu Bo patches which add the ability > to set the NOCOW flags to a btrfs file.[1] > > However it seems that it was not present in the current (v1.42.3) > e2fsprogs suite. > > There is any r

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Goffredo Baroncelli
On 06/10/2012 08:47 AM, Goffredo Baroncelli wrote: > Hi all, > > which is the supposed corrected way to set the file flag FS_NOCOW_FL ? I > know that exists the associated ioctl FS_IOC_SETFLAGS; which I didn't > found is an user-space tool to use to set the flags. > > I am missing something ? Af