On Thu, Sep 30, 2010 at 01:38:07AM +0200, Jan Kara wrote:
> > No. For one thing we don't need any exception for correctnes alone -
> > even the block device variant would work fine with the default case.
> Here I don't agree. If you don't have some kind of exception, sb->s_bdi
> for both "block" a
On Wed 29-09-10 16:10:06, Christoph Hellwig wrote:
> On Wed, Sep 29, 2010 at 02:18:08PM +0200, Jan Kara wrote:
> > On Wed 29-09-10 10:19:36, Christoph Hellwig wrote:
> > > ---
> > > From: Christoph Hellwig
> > > Subject: [PATCH] writeback: always use sb->s_bdi for writeback purposes
> > >
> > ...
On Wed, Sep 29, 2010 at 02:18:08PM +0200, Jan Kara wrote:
> On Wed 29-09-10 10:19:36, Christoph Hellwig wrote:
> > ---
> > From: Christoph Hellwig
> > Subject: [PATCH] writeback: always use sb->s_bdi for writeback purposes
> >
> ...
> > The one exception for now is the block device filesystem whi
595920ddedfa-3ece6b56e80f689e devid 1 transid 22342
> > > > > > /dev/mapper/vg_cesarbinspiro-lv_home
> > > > > > SELinux: initialized (dev dm-3, type btrfs), uses xattr
> > > > > > [ cut here ]
> > > > > > WARNING: at
devid 1 transid 22342
> >>>/dev/mapper/vg_cesarbinspiro-lv_home
> >>>SELinux: initialized (dev dm-3, type btrfs), uses xattr
> >>>[ cut here ]
> >>>WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
> >>>Hardwar
t; > > > --------[ cut here ]--------
> > > > > WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
> > > > > Hardware name: Inspiron N4010
> > > > > Dirtiable inode bdi default != sb bdi btrfs
> > > > > Modules linke
On Wed 29-09-10 10:19:36, Christoph Hellwig wrote:
> ---
> From: Christoph Hellwig
> Subject: [PATCH] writeback: always use sb->s_bdi for writeback purposes
>
...
> The one exception for now is the block device filesystem which really
> wants different writeback contexts for it's different (inter
Here is the patch that I already proposed a while ago. I've tested
xfstests on btrfs and xfstests to make sure the btrfs issue is fixed,
and I've also tested the original dirtying of device files issue
and I/O operations on block device files to test the special case
in the patch.
---
From: Chris
fa-3ece6b56e80f689e devid 1 transid 22342
> > > > /dev/mapper/vg_cesarbinspiro-lv_home
> > > > SELinux: initialized (dev dm-3, type btrfs), uses xattr
> > > > [ cut here ]----
> > > > WARNING: at fs/fs-writeback.c:87 inode_to_bd
[ cut here ]
WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
Hardware name: Inspiron N4010
Dirtiable inode bdi default != sb bdi btrfs
That suggests that we should probably handle such cases in a more generic
way by changing the code in inode_init_always(). The
fa-3ece6b56e80f689e devid 1 transid 22342
> > > > /dev/mapper/vg_cesarbinspiro-lv_home
> > > > SELinux: initialized (dev dm-3, type btrfs), uses xattr
> > > > [ cut here ]----
> > > > WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
lv_home
> > > SELinux: initialized (dev dm-3, type btrfs), uses xattr
> > > [ cut here ]
> > > WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
> > > Hardware name: Inspiron N4010
> > > Dirtiable inode bdi default != sb bdi btrfs
>
> > WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
> > Hardware name: Inspiron N4010
> > Dirtiable inode bdi default != sb bdi btrfs
> > Modules linked in: ipv6 kvm_intel kvm uinput arc4 ecb
> > snd_hda_codec_intelhdmi snd_hda_codec_realtek iwlagn s
gt; /dev/mapper/vg_cesarbinspiro-lv_home
> >>>> SELinux: initialized (dev dm-3, type btrfs), uses xattr
> >>>> [ cut here ]
> >>>> WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
> >>>> Hardware name: Inspir
ning.
>>>>
>>>> [...]
>>>> device fsid 44d595920ddedfa-3ece6b56e80f689e devid 1 transid 22342
>>>> /dev/mapper/vg_cesarbinspiro-lv_home
>>>> SELinux: initialized (dev dm-3, type btrfs), uses xattr
>>>> [ cut here
fsid 44d595920ddedfa-3ece6b56e80f689e devid 1 transid 22342
> >> /dev/mapper/vg_cesarbinspiro-lv_home
> >> SELinux: initialized (dev dm-3, type btrfs), uses xattr
> >> ----[ cut here ]--------
> >> WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
>
initialized (dev dm-3, type btrfs), uses xattr
>> [ cut here ]
>> WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
>> Hardware name: Inspiron N4010
>> Dirtiable inode bdi default != sb bdi btrfs
>> Modules linked in: ipv6 kvm_intel kvm uinput arc
On Thu, Sep 23, 2010 at 12:38:49PM -0700, Andrew Morton wrote:
>
> (Cc sta...@kernel.org)
>
> On Wed, 22 Sep 2010 21:54:30 -0300
> Cesar Eduardo Barros wrote:
>
> > This started appearing for me on v2.6.36-rc5-49-gc79bd89; it did not
> > happen on v2.6.36-rc5-33-g1ce1e41, probably because it d
eback.c:87 inode_to_bdi+0x62/0x6d()
> Hardware name: Inspiron N4010
> Dirtiable inode bdi default != sb bdi btrfs
> Modules linked in: ipv6 kvm_intel kvm uinput arc4 ecb
> snd_hda_codec_intelhdmi snd_hda_codec_realtek iwlagn snd_hda_intel
> iwlcore snd_hda_codec uvcvideo snd_hwdep mac8021
/dev/mapper/vg_cesarbinspiro-lv_home
SELinux: initialized (dev dm-3, type btrfs), uses xattr
[ cut here ]
WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x62/0x6d()
Hardware name: Inspiron N4010
Dirtiable inode bdi default != sb bdi btrfs
Modules linked in: ipv6 kvm_intel kvm
20 matches
Mail list logo
