Re: Proper error handling on NULL pointers

2009-10-30 Thread Chris Mason
On Fri, Oct 30, 2009 at 09:27:36AM -0400, Jeff Mahoney wrote: > On 10/26/2009 05:14 AM, Chris Mason wrote: > > On Fri, Oct 23, 2009 at 02:08:48PM -0400, Jeff Mahoney wrote: > >> On 10/22/2009 06:15 AM, Andi Drebes wrote: > I don't know what is the developer plan to fix that - apparently it's >

Re: Proper error handling on NULL pointers

2009-10-30 Thread Jeff Mahoney
On 10/26/2009 05:14 AM, Chris Mason wrote: > On Fri, Oct 23, 2009 at 02:08:48PM -0400, Jeff Mahoney wrote: >> On 10/22/2009 06:15 AM, Andi Drebes wrote: I don't know what is the developer plan to fix that - apparently it's not in the high-priority list (but it must be certainly in the pri

Re: Proper error handling on NULL pointers

2009-10-26 Thread Jeff Mahoney
On 10/26/2009 05:14 AM, Chris Mason wrote: > On Fri, Oct 23, 2009 at 02:08:48PM -0400, Jeff Mahoney wrote: >> On 10/22/2009 06:15 AM, Andi Drebes wrote: I don't know what is the developer plan to fix that - apparently it's not in the high-priority list (but it must be certainly in the pri

Re: Proper error handling on NULL pointers

2009-10-26 Thread Chris Mason
On Wed, Oct 21, 2009 at 07:43:51PM +0200, Diego Calleja wrote: > On Lunes 19 Octubre 2009 12:36:13 Andi Drebes escribió: > > However, is there any interest in patches fixing these problems? If yes: > > what would be the best strategy? Should we start fixing this "layer by > > layer" -- the low-le

Re: Proper error handling on NULL pointers

2009-10-26 Thread Chris Mason
On Fri, Oct 23, 2009 at 02:08:48PM -0400, Jeff Mahoney wrote: > On 10/22/2009 06:15 AM, Andi Drebes wrote: > >> I don't know what is the developer plan to fix that - apparently it's > >> not in the high-priority list (but it must be certainly in the priority > >> list, anyone who gets out of memory

Re: Proper error handling on NULL pointers

2009-10-23 Thread Jeff Mahoney
On 10/22/2009 06:15 AM, Andi Drebes wrote: >> I don't know what is the developer plan to fix that - apparently it's >> not in the high-priority list (but it must be certainly in the priority >> list, anyone who gets out of memory using btrfs will have some chances of >> getting an oops [...]). > I'

Re: Proper error handling on NULL pointers

2009-10-22 Thread Andi Drebes
> > I'd really appreciate to see a TODO section somewhere in the wiki. [..] > > There's one (needs updating): > http://btrfs.wiki.kernel.org/index.php/Development_timeline > Also, http://btrfs.wiki.kernel.org/index.php/Project_ideas has some ideas. Yes, I've already seen them. They are quite feat

Re: Proper error handling on NULL pointers

2009-10-22 Thread Diego Calleja
On Jueves 22 Octubre 2009 12:15:59 Andi Drebes escribió: > I'd really appreciate to see a TODO section somewhere in the wiki. [..] There's one (needs updating): http://btrfs.wiki.kernel.org/index.php/Development_timeline Also, http://btrfs.wiki.kernel.org/index.php/Project_ideas has some ideas. -

Re: Proper error handling on NULL pointers

2009-10-22 Thread Andi Drebes
> I don't know what is the developer plan to fix that - apparently it's > not in the high-priority list (but it must be certainly in the priority > list, anyone who gets out of memory using btrfs will have some chances of > getting an oops [...]). I'd really appreciate to see a TODO section somewhe

Re: Proper error handling on NULL pointers

2009-10-21 Thread Diego Calleja
On Lunes 19 Octubre 2009 12:36:13 Andi Drebes escribió: > However, is there any interest in patches fixing these problems? If yes: what > would be the best strategy? Should we start fixing this "layer by layer" -- > the low-level functions first and the high-level functions later on? Or > should

Proper error handling on NULL pointers

2009-10-19 Thread Andi Drebes
Hi! I recently posted a message that addresses the usage of BUG_ON for memory shortages concerning btrfs_alloc_path() (see [1]): ... path = btrfs_alloc_path(); BUG_ON(!path); ret = btrfs_search_slot(NULL, root, &search_key, path, 0, 0); ... It seems that t