Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-10 Thread Jeff Mahoney
On 9/10/16 11:58 AM, Sean Fu wrote: > On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: >> On 9/8/16 11:08 PM, Sean Fu wrote: >>> On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: On 9/6/16 5:58 AM, David Sterba wrote: > On Mon, Sep 05, 2016 at 11:13:40PM -0400,

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-10 Thread Sean Fu
On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: > On 9/8/16 11:08 PM, Sean Fu wrote: > > On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > >> On 9/6/16 5:58 AM, David Sterba wrote: > >>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > >> Since root

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-08 Thread Sean Fu
On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: > On 9/8/16 11:08 PM, Sean Fu wrote: > > On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > >> On 9/6/16 5:58 AM, David Sterba wrote: > >>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > >> Since root

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-08 Thread Jeff Mahoney
On 9/8/16 11:08 PM, Sean Fu wrote: > On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: >> On 9/6/16 5:58 AM, David Sterba wrote: >>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: >> Since root is only used to get fs_info->chunk_root, why not use fs_info >>

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-08 Thread Sean Fu
On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > On 9/6/16 5:58 AM, David Sterba wrote: > > On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > Since root is only used to get fs_info->chunk_root, why not use fs_info > directly? > >>> > >>> Weird. Exactly this

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Qu Wenruo
At 09/07/2016 09:38 AM, Sean Fu wrote: On Mon, Sep 05, 2016 at 03:56:41PM +0800, Qu Wenruo wrote: At 09/05/2016 09:19 AM, Zhao Lei wrote: Hi, Sean Fu From: Sean Fu [mailto:fxinr...@gmail.com] Sent: Sunday, September 04, 2016 7:54 PM To: dste...@suse.com Cc: c...@fb.com;

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Sean Fu
On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > On 9/6/16 5:58 AM, David Sterba wrote: > > On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > Since root is only used to get fs_info->chunk_root, why not use fs_info > directly? > >>> > >>> Weird. Exactly this

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Sean Fu
On Mon, Sep 05, 2016 at 03:56:41PM +0800, Qu Wenruo wrote: > > > At 09/05/2016 09:19 AM, Zhao Lei wrote: > >Hi, Sean Fu > > > >>From: Sean Fu [mailto:fxinr...@gmail.com] > >>Sent: Sunday, September 04, 2016 7:54 PM > >>To: dste...@suse.com > >>Cc: c...@fb.com; anand.j...@oracle.com;

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Jeff Mahoney
On 9/6/16 5:58 AM, David Sterba wrote: > On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: Since root is only used to get fs_info->chunk_root, why not use fs_info directly? >>> >>> Weird. Exactly this was a part of my fs_info patchset. I guess I need >>> to go back and

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread David Sterba
On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > >> Since root is only used to get fs_info->chunk_root, why not use fs_info > >> directly? > > > > Weird. Exactly this was a part of my fs_info patchset. I guess I need > > to go back and check what else is missing. > > Actually,

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-05 Thread Jeff Mahoney
On 9/5/16 11:05 PM, Jeff Mahoney wrote: > On 9/5/16 3:56 AM, Qu Wenruo wrote: >> >> >> At 09/05/2016 09:19 AM, Zhao Lei wrote: >>> Hi, Sean Fu >>> From: Sean Fu [mailto:fxinr...@gmail.com] Sent: Sunday, September 04, 2016 7:54 PM To: dste...@suse.com Cc: c...@fb.com;

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-05 Thread Jeff Mahoney
On 9/5/16 3:56 AM, Qu Wenruo wrote: > > > At 09/05/2016 09:19 AM, Zhao Lei wrote: >> Hi, Sean Fu >> >>> From: Sean Fu [mailto:fxinr...@gmail.com] >>> Sent: Sunday, September 04, 2016 7:54 PM >>> To: dste...@suse.com >>> Cc: c...@fb.com; anand.j...@oracle.com; fdman...@suse.com; >>>

RE: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-05 Thread Zhao Lei
x-btrfs@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] Btrfs: remove unnecessary code of chunk_root > assignment in btrfs_read_chunk_tree. > > > > At 09/05/2016 09:19 AM, Zhao Lei wrote: > > Hi, Sean Fu > > > >> From: Sean Fu [mai

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-05 Thread Qu Wenruo
At 09/05/2016 09:19 AM, Zhao Lei wrote: Hi, Sean Fu From: Sean Fu [mailto:fxinr...@gmail.com] Sent: Sunday, September 04, 2016 7:54 PM To: dste...@suse.com Cc: c...@fb.com; anand.j...@oracle.com; fdman...@suse.com; zhao...@cn.fujitsu.com; linux-btrfs@vger.kernel.org;

RE: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-04 Thread Zhao Lei
Hi, Sean Fu > From: Sean Fu [mailto:fxinr...@gmail.com] > Sent: Sunday, September 04, 2016 7:54 PM > To: dste...@suse.com > Cc: c...@fb.com; anand.j...@oracle.com; fdman...@suse.com; > zhao...@cn.fujitsu.com; linux-btrfs@vger.kernel.org; > linux-ker...@vger.kernel.org; Sean Fu