RE: [PATCH] btrfs-progs: mkfs: Enable -d dup for single device

2015-10-13 Thread Zhao Lei
Hi, David Sterba > -Original Message- > From: David Sterba [mailto:dste...@suse.cz] > Sent: Tuesday, October 13, 2015 8:36 PM > To: Zhao Lei <zhao...@cn.fujitsu.com> > Cc: dste...@suse.cz; linux-btrfs@vger.kernel.org; c...@fb.com > Subject: Re: [PATCH] btrfs-pr

Re: [PATCH] btrfs-progs: mkfs: Enable -d dup for single device

2015-10-13 Thread David Sterba
On Tue, Oct 13, 2015 at 07:40:30PM +0800, Zhao Lei wrote: > > What I remember from the comment is that "it's slightly offset that would > > lead > > to corruption". > > Before this patch, I had done git blame to search why the condition was added, > and hadn't found the exact reason. found it:

Re: [PATCH] btrfs-progs: mkfs: Enable -d dup for single device

2015-10-13 Thread David Sterba
On Tue, Oct 13, 2015 at 06:29:41PM +0800, Zhao Lei wrote: > Current code don't support dup profile in single device, except it > is in mixed mode, because following reason: > 1: In some ssd with deduplication function, it have no effect. > 2: For a physical device, it the entire disk broken, -d

RE: [PATCH] btrfs-progs: mkfs: Enable -d dup for single device

2015-10-13 Thread Zhao Lei
Hi, David Sterba Thanks for review. > -Original Message- > From: David Sterba [mailto:dste...@suse.cz] > Sent: Tuesday, October 13, 2015 7:29 PM > To: Zhao Lei <zhao...@cn.fujitsu.com> > Cc: linux-btrfs@vger.kernel.org; c...@fb.com > Subject: Re: [PATCH] btrfs-pr