Re: [PATCH] Btrfs: fix assertion failure when freeing block groups at close_ctree()

2017-02-02 Thread Liu Bo
On Thu, Feb 02, 2017 at 06:58:03PM +, Filipe Manana wrote: > On Thu, Feb 2, 2017 at 6:53 PM, Liu Bo wrote: > > On Thu, Feb 02, 2017 at 06:32:01PM +, Filipe Manana wrote: > >> On Thu, Feb 2, 2017 at 6:19 PM, Liu Bo wrote: > >> > On Wed, Feb 01, 2017 at 11:01:28PM +, fdman...@kernel.org

Re: [PATCH] Btrfs: fix assertion failure when freeing block groups at close_ctree()

2017-02-02 Thread Filipe Manana
On Thu, Feb 2, 2017 at 6:53 PM, Liu Bo wrote: > On Thu, Feb 02, 2017 at 06:32:01PM +, Filipe Manana wrote: >> On Thu, Feb 2, 2017 at 6:19 PM, Liu Bo wrote: >> > On Wed, Feb 01, 2017 at 11:01:28PM +, fdman...@kernel.org wrote: >> >> From: Filipe Manana >> >> >> >> At close_ctree() we free

Re: [PATCH] Btrfs: fix assertion failure when freeing block groups at close_ctree()

2017-02-02 Thread Liu Bo
On Thu, Feb 02, 2017 at 06:32:01PM +, Filipe Manana wrote: > On Thu, Feb 2, 2017 at 6:19 PM, Liu Bo wrote: > > On Wed, Feb 01, 2017 at 11:01:28PM +, fdman...@kernel.org wrote: > >> From: Filipe Manana > >> > >> At close_ctree() we free the block groups and then only after we wait for > >>

Re: [PATCH] Btrfs: fix assertion failure when freeing block groups at close_ctree()

2017-02-02 Thread Filipe Manana
On Thu, Feb 2, 2017 at 6:19 PM, Liu Bo wrote: > On Wed, Feb 01, 2017 at 11:01:28PM +, fdman...@kernel.org wrote: >> From: Filipe Manana >> >> At close_ctree() we free the block groups and then only after we wait for >> any running worker kthreads to finish and shutdown the workqueues. This >>

Re: [PATCH] Btrfs: fix assertion failure when freeing block groups at close_ctree()

2017-02-02 Thread Liu Bo
On Wed, Feb 01, 2017 at 11:01:28PM +, fdman...@kernel.org wrote: > From: Filipe Manana > > At close_ctree() we free the block groups and then only after we wait for > any running worker kthreads to finish and shutdown the workqueues. This > behaviour is racy and it triggers an assertion failu