Re: [PATCH] btrfs: Remove logically dead code from btrfs_orphan_cleanup

2018-09-14 Thread David Sterba
On Thu, Sep 13, 2018 at 11:35:00AM +0300, Nikolay Borisov wrote: > In btrfs_orphan_cleanup the final 'if (ret) goto out' cannot ever be > executed. This is due to the last assignment to 'ret' depending on > the return value of btrfs_iget. If an error other than -ENOENT is > returned then the loop i

Re: [PATCH] btrfs: Remove logically dead code from btrfs_orphan_cleanup

2018-09-13 Thread Lu Fengqi
On Thu, Sep 13, 2018 at 11:35:00AM +0300, Nikolay Borisov wrote: >In btrfs_orphan_cleanup the final 'if (ret) goto out' cannot ever be >executed. This is due to the last assignment to 'ret' depending on >the return value of btrfs_iget. If an error other than -ENOENT is >returned then the loop is pr